IMP-009: extend StockIssuanceType enum for stock dividends - #9
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The documentation now aligns with the existing stock issuance schema and enum semantics.
Review effort: Balanced
Findings: None
What changed in this PR
Clarifies the proposed OCF-IMP-009 approach for identifying stock dividend issuances.
Changes:
- Recommends extending
StockIssuanceTypewithSTOCK_DIVIDENDandDRIP. - Rejects a parallel overlapping
reasonfield.
| File | Description |
|---|---|
fairmint-ocf-improvements.md |
Updates the stock-dividend design direction. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Corrects the OCF-IMP-009 direction after review (#7, post-merge Copilot finding): stock dividends / DRIP should extend the existing
issuance_typeenum (StockIssuanceType—RSA,FOUNDERS_STOCK) withSTOCK_DIVIDEND/DRIPvalues, not add a parallelreasonclassifier field that would overlap withissuance_type.Companion write-up: Fairmint/dev-docs#148
Which issue(s) this PR fixes:
Fixes #
Made with Cursor