Repository navigation
fix(compare): gate regressions on the binary under test - #287
Merged
Merged
Conversation
![ferrfleet-interne[bot]](https://avatars.githubusercontent.com/in/5311663?s=60&v=4){kind=small}
There was a problem hiding this comment.
Correct. The relative gate now covers only -ferrflow-binary- keys, which matches the existing absolute thresholds, and the new bats case covers npm/docker being ignored. The binary size now comes from the binary on PATH, the same one being timed, not a freshly downloaded npm package. One nit inline.
Expect one benign size delta on the first run against an old baseline: du -m rounded up to whole MiB, while the new value is exact.
There was a problem hiding this comment.
The stat -L nit is fixed in 58715be. Nothing else has changed since my last approval, and I have nothing new to raise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The relative check now only considers
-ferrflow-binary-keys, so npm and docker (published release) timings no longer fail a PR.ferrflow_binary_size_mbis now the size of theferrflowbinary on PATH (the one under test) instead of the npm-published package.Adds a
compare.batscase with regressing npm/docker keys that must not fail. bats is not installed locally, so the new case was not run here; the equivalent script run exited 0.Closes #284