Repository navigation
ci(coverage): generate coverage with cargo-llvm-cov - #1357
Merged
Merged
Conversation
The ptrace engine segfaulted mid-run on the v7.35.0 release commit, which changes no code; the previous run on the same tree passed. The LLVM engine instruments at compile time instead of tracing the test process, which removes this class of flaky segfault. Signed-off-by: BryanFRD <bryanferrando59@gmail.com>
Tarpaulin's llvm engine fails to parse the profiles rustc 1.99 writes ("consistency check for reading counts failed"), and its ptrace engine segfaults intermittently. cargo-llvm-cov reads profiles with the toolchain's own llvm-tools, so the format always matches. The cobertura report keeps repo-relative src/ paths, so Sonar and Codecov consume it unchanged.
Signed-off-by: BryanFRD <bryanferrando59@gmail.com>
BryanFRD
changed the title
![ferrfleet-interne[bot]](https://avatars.githubusercontent.com/in/5311663?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Approve: the switch to cargo-llvm-cov is correct (llvm-tools-preview added, cobertura.xml path unchanged for Sonar and Codecov). Nit: the PR title still says "tarpaulin with the llvm engine", so it should be updated before the squash commit lands in the changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Coverage job segfaulted under tarpaulin's ptrace engine on the v7.35.0 release commit (https://github.com/FerrLabs/FerrFlow/actions/runs/40565366095), which changes no code; the previous run on the same tree passed.
Switching tarpaulin to
--engine llvmfailed differently: its bundled profile parser can't read what rustc 1.99 writes (consistency check for reading counts failed).This replaces tarpaulin with
cargo-llvm-cov, which uses the toolchain's ownllvm-tools, so the profile format always matches rustc. The cobertura report keeps repo-relativesrc/paths, so the Sonar and Codecov steps are unchanged. Locally: 1300 + 1926 tests pass, 91% line coverage.