Repository navigation
chore(supply-chain): bump json5 exemption to 1.3.6 - #1360
Merged
Merged
Conversation
Signed-off-by: BryanFRD <bryanferrando59@gmail.com>
Contributor
|
Ready to merge. The review found no issues. Formal verification did not run, so there is no result from it. Review: Formal verification: the run failed and returned no result. Nothing is claimed either way. A one-line exemption bump has no code properties to check, so this probably doesn't matter here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1359 moved json5 to 1.3.6 without updating the exemption, so
cargo vethas failed onmainsince.I read the 1.3.4 to 1.3.6 crate diff:
parse_numberinlines a helper, and the tests change. No new dependency, unsafe code or I/O.cargo vetpasses locally.