Repository navigation
fix(git): ignore prefix-sharing tags that are not versions - #1363
Merged
Merged
Conversation
Signed-off-by: BryanFRD <bryanferrando59@gmail.com>
Signed-off-by: BryanFRD <bryanferrando59@gmail.com>
Signed-off-by: BryanFRD <bryanferrando59@gmail.com>
Contributor
There was a problem hiding this comment.
Approve. is_version_tag correctly rejects prefix-sharing tags (vendor-sync, core-utils-1.0.1) in the TagIndex lookups and prefixed_tags, and it accepts the formats the versioning strategies emit (semver, calver, sequential, v-prefixed, pre-release). The three new tests in src/git/tests.rs cover the main cases. Two other prefix matchers still use plain starts_with, so the ambiguity is not fully gone.
Findings (both minor, not inline)
- minor,
src/monorepo/util.rs:8:tags_for_packagefilters witht.starts_with(prefix). For prefixcore-it still returnscore-utils-1.0.1. It feeds impact, cascade, version_hook, upgrade (effective_versioning detection) and why, so those paths can still pick up a sibling package's tags. Fix: makeis_version_tagpub(crate)(re-export fromcrate::git) and use.filter(|t| is_version_tag(t, prefix)). - minor,
src/rollback/mod.rs:71:tag_ownerusestag.starts_with(&prefix)with.next(), socore-utils-1.0.1is claimed bycoreif it is listed first. A narrowed rollback can then target the wrong package. Fix: useis_version_tag(tag, &prefix).
Formal verification: the step failed and returned no result, so nothing was verified formally.
ferrflow Bot
added a commit
that referenced
this pull request
Oct 31, 2026
## [7.35.3] - 2026-10-31 ### Bug Fixes - fix(git): ignore prefix-sharing tags that are not versions (#1363)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag lookups accepted any tag starting with the package prefix, so tags like
vendor-syncorcore-utils-1.0.1(prefixcore-) cut the prerelease commit range and the missed-release touch check.The prefix match now also requires the remainder to be a dotted numeric version (optional
v, prerelease/build suffix allowed). Tests cover both repros and confirmpkg-v1.1.0-beta.1still counts.Closes #1342