Skip to content

ci(dco): require a sign-off on every commit - #265

Merged
BryanFRD merged 2 commits into
mainfrom
ci/dco
Oct 26, 2026
Merged

BryanFRD merged 2 commits into
mainfrom
ci/dco

Conversation

@BryanFRD

Copy link
Copy Markdown
Contributor

Adds the shared DCO check (FerrLabs/.github reusable-dco). Every commit of a PR needs a Signed-off-by line; fix with git rebase --signoff origin/main. Renovate signs off through the shared preset.

Signed-off-by: BryanFRD <bryanferrando59@gmail.com>

@ferrfleet-interne ferrfleet-interne Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct: the caller is pinned to a SHA, has contents: read only, and runs on pull_request, not pull_request_target. Since the reusable workflow checks out with fetch-depth: 0, origin/${BASE_REF}..HEAD_SHA resolves. One nit inline.

Comment thread .github/workflows/dco.yml Resolved
Co-authored-by: ferrfleet-interne[bot] <342363332+ferrfleet-interne[bot]@users.noreply.github.com>
@BryanFRD
BryanFRD enabled auto-merge (squash) October 26, 2026 17:38

@ferrfleet-interne ferrfleet-interne Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The edited nit is fixed in d391eff.

Blocking: d391eff has no Signed-off-by: trailer, so the new sign-off / sign-off check fails on this PR. Fix with git rebase --signoff origin/main and push (a force-push is needed since the history is rewritten).

Worth knowing once this lands: GitHub's "Commit suggestion" button creates commits without a sign-off, so every accepted suggestion will trip this check until it is amended.

@BryanFRD
BryanFRD disabled auto-merge October 26, 2026 17:39
@BryanFRD
BryanFRD merged commit ad4d776 into main Oct 26, 2026
11 of 12 checks passed
@BryanFRD
BryanFRD deleted the ci/dco branch October 26, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant