Repository navigation
feat(frontend): resolve Storybook component stories and prevent dark mode flicker (#1478, #1482) - #1507
Merged
joelpeace48-cell merged 1 commit intoOct 22, 2026
Conversation
…mode flicker (FinesseStudioLab#1478, FinesseStudioLab#1482) - FinesseStudioLab#1478: Add CampaignCard stories for loading, active, ended, claimed, and featured states. Implement RewardBadge and ClaimButton components with full Storybook stories. Configure Chromatic visual diff step in CI workflow. - FinesseStudioLab#1482: Move inline theme pre-initialization script to <head> in index.html to apply theme dataset, color-scheme, and class before render, eliminating white flash on initial load. Add Playwright visual test for dark mode initial load. Closes FinesseStudioLab#1478, Closes FinesseStudioLab#1482
|
@Queenode Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
joelpeace48-cell
merged commit Oct 22, 2026
ad93b9d
into
FinesseStudioLab:main
5 of 21 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Targeted fixes addressing the 2 assigned frontend issues (#1478, #1482) for @Queenode in Stellar Wave:
frontend: Storybook stories missing for core campaign card components #1478 — Storybook stories missing for core campaign card components
CampaignCardin all core states:Loading,Active,Ended,Claimed,Featured,Upcoming, andDarkMode.RewardBadgeandClaimButtoncomponents with full Storybook stories (frontend/src/stories/RewardBadge.stories.jsx,frontend/src/stories/ClaimButton.stories.jsx)..github/workflows/visual-regression.yml.frontend: dark mode flicker on initial page load due to missing theme pre-init script #1482 — Dark mode flicker on initial page load
<head>before render inindex.html.data-theme,style.colorScheme, theme class, and immediate background color on the root element before first paint to completely eliminate the white background flash on hard reload.frontend/tests/visual/pages.spec.ts.Motivation / Context
Closes #1478
Closes #1482
Changes
frontend/index.html: Moved theme script to head to pre-initialize theme dataset, color-scheme, class, and background.frontend/src/components/RewardBadge.jsx: Created RewardBadge component.frontend/src/components/ClaimButton.jsx: Created ClaimButton component.frontend/src/stories/CampaignCard.stories.jsx: Added stories for loading, active, ended, claimed, and featured states.frontend/src/stories/RewardBadge.stories.jsx: Storybook stories for RewardBadge.frontend/src/stories/ClaimButton.stories.jsx: Storybook stories for ClaimButton.frontend/tests/visual/pages.spec.ts: Added visual test for dark mode initial load without flash..github/workflows/visual-regression.yml: Configured Chromatic visual diff step in CI.