Fix hatch IEnumerator CheckForConnections to support PhysicsHold mod - #537
Merged
Merged
Conversation
When PhysicsHold is installed an enabled on a base, a few bugs occur. The most annoying one is that hatches from inside the base cease to function with FreeIVA. This is because the vessel appears in a packed state. Since you can only open hatches in FreeIVA mode on a packed vessel you are actually inside (and the bug does not occur from outside), simply checking if we are the active vessel before yielding null should suffice.
Collaborator
|
@R-T-B Does CheckForConnection run again when you enter IVA mode? Because otherwise you could end up with hatches that aren't connected because this ran before the active vessel was unpacked (I think). |
Contributor
Author
I've been using this patchset for a month in my personal save now and have yet to see an unconnected hatch on an active Vessel, so I don't think that happens like that. But I admitedly have not tested literally every scenario. Any suggestions on how to do this better would be welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When PhysicsHold is installed an enabled on a base, a few bugs occur. The most annoying one is that hatches from inside the base cease to function with FreeIVA. This is because the vessel appears in a packed state.
Since you can only open hatches in FreeIVA mode on a packed vessel you are actually inside (and the bug does not occur from outside), simply checking if we are the active vessel before yielding null should suffice.