Repository navigation
fix(tournaments): 오늘 대회 코드를 공개 API에서 숨김 - #31
Merged
Merged
Conversation
현장 확인용 코드가 로그인 없이 조회되던 것을 막고, 운영자와 관리자만 값을 보게 했다. Co-authored-by: park gun hyung <qkrrjsgud49@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
왜
오늘의 대회 코드는 현장에 있는 사람만 알게 하려는 확인 수단인데,
GET /tournaments/:id/day-code가 로그인 없이 코드 값을 돌려주고 있었습니다. 누구나 코드를 읽어 원격으로 제출할 수 있습니다.무엇을 바꿨나
hasCode)만 반환합니다. 코드 문자열은 포함하지 않습니다.GET /tournaments/organized/:id/day-code로 값을 봅니다.검증
npm test --prefix apps/api(104 passed)npm run build --prefix apps/apinpm run build --prefix apps/webpython3 -m unittest discover -s ai/tests -t ai화면
해당 없음
마이그레이션
없음. 환경 변수 변경 없음.