Repository navigation
Solve again on the residual when fixed effects explain most of a variable - #87
Closed
matthieugomez wants to merge 1 commit into
Closed
matthieugomez wants to merge 1 commit into
matthieugomez wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
=======================================
Coverage ? 59.95%
=======================================
Files ? 12
Lines ? 1251
Branches ? 0
=======================================
Hits ? 750
Misses ? 501
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lsmr!stops relative to the norm of its right-hand side, so a variable with a large mean, or one mostly explained by the fixed effects, kept an error that was large relative to its residual: with a mean of 1e6 andtol = 1e-6, the residuals were off by about 16%.solve_residuals!now solves again on the residual when its norm is belowsqrt(tol)times that of the right-hand side, so the residuals of a variable no longer depend on its mean. Ordinary variables never trigger the second solve; the only added cost is two norms.