Skip to content

Fix bidiag return inference #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eloualiche merged 2 commits into from
Nov 2, 2026
Merged

Fix bidiag return inference #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
568d537
Keep CPU bidiagonalization norm inferred
gragusa Oct 31, 2026
8f4fdd7
Test for bidiagonal inference
gragusa Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/CPU.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,8 @@ function bidiag_forward!(u::Vector{T}, g::FixedEffectCoefficients, fem::FixedEff
# serial: everything in one pass, gathers accumulated directly into g
s = _bidiag_chunk!(u, gs, blocks, qrowss, vs, T(c), eachindex(u))
end
return T(sqrt(s))
# The asserted norm type prevents boxing in LSMR's scalar recurrences.
return T(sqrt(s))::T
end

# u[i] ← c * u[i] + Σ_blocks fit_i; accumulates each block's gather into
Expand Down
10 changes: 10 additions & 0 deletions test/solve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,16 @@ r_ols = [-0.2015993617092453, 0.2015993617092464, -0.2015993617092463, 0.2015
@test iterz == 0
@test all(iszero, rz)

@testset "Inferred bidiagonalization norm" begin
for T in (Float32, Float64)
solver = FixedEffects.AbstractFixedEffectSolver{T}(fes, uweights(T, length(x)), Val{:cpu})
u = T.(x)
fill!(solver.v, one(T))
@test (@inferred FixedEffects.bidiag_forward!(
u, solver.g, solver.m, solver.v, zero(T))) isa T
end
end

@testset "maxiter semantics" begin
(r0, iter0, conv0) = @test_logs (:warn, r"solve_residuals!") solve_residuals!(deepcopy(x), fes; maxiter = 0)
@test iter0 == 0
Expand Down
Loading