Fix Generate Pages Script Deps - #245
Merged
Merged
Conversation
ihassanein
requested review from
aaparent,
aviau,
ireydiak,
jenip13 and
xvaier
as code owners
August 3, 2026 20:45
jenip13
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I investigated why it seemed to hang when generating pages.
David also had this issue last week, and mentioned scraper version 4.0.900 worked for them, so I started there. It does work, but I wasn't happy leaving it since 4.0.900 is about 35 releases behind, and pinning just means we're frozen until someone remembers to bump it. It also didn't explain anything, so we'd walk into the same wall on the next
@latestbump.I got Claude to walk through the versions to find where it breaks using the same conditions for each back to back.
The result was:
The only difference between those two releases is
@mintlify/commonwent 1.0.1056 -> 1.0.1057, which bumped@mintlify/mdxfrom 3.0.4 -> 4.0.1.@mintlify/mdx4.0.1 added peerDependencies onreact,react-domand@base-ui/react. npm 7+ installs peer deps automatically... which is what was breaking. So basically, npm would never finish and we would never get to the good part (scraping).openapi-filejust reads a local JSON spec. It doesn't touch any of the React stuff, so we don't need to resolve those peers. So again with Claude we addedexport NPM_CONFIG_LEGACY_PEER_DEPS=trueto skip resolving those peers entirely. No pinning needed we can stay on@latestand is only scoped to the script so should not affect anything else.Claude has some tradeoffs it would like to present that I didn't address in this MR: