Repository navigation
chronos-enzh-50m-sft driver: certifi CAs for --download, refuse before loading - #51
Merged
Merged
Conversation
- download() uses certifi's CA bundle when installed. python.org macOS builds ship no system CAs, so urlretrieve failed with CERTIFICATE_VERIFY_FAILED. A failed download now removes the partial file and says how to fetch the weights by hand. - The CLI runs the language check before building the Translator, so Chinese input is refused (exit 2) even when the weights are absent, instead of failing with "weights not found". - Two tests cover both paths. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two driver fixes, found while testing
translate.pyfrom a fresh directory after theenzh-50m-sft-v1release.--downloadon python.org macOS Python. That build ships no system CA bundle, sourlretrievefailed withCERTIFICATE_VERIFY_FAILED. The fix:download()now uses certifi's CA bundle when it is installed. certifi comes in through the transformers → huggingface_hub → httpx dependency chain.Translator, so out-of-boundary input is refused with exit code 2 and nothing is loaded or downloaded.Test plan
ruff==0.17.4andflake8 --select=E9,F63,F7,F82are clean..partfile.::1on the test machine, so a localhost server provided the weights:--direction zh_enexit with code 2.57c59a14…fab4b7.🤖 Generated with Claude Code