UX: Escape does not dismiss the New File modal

[Fooftilly]

Status: Fixed by #131.

Source: automated UX audit (Grok Bot)
Last verified: master@dc50f9b
Surface: Work
Classification: ACCESSIBILITY
Confidence: high

Security: Do not use this public issue for a suspected vulnerability, security-boundary bypass, exploit details, secrets, private data, or a sensitive reproduction. Follow the private reporting process in SECURITY.md instead.

Finding

Pressing Escape does not dismiss the New File modal. The dialog stays open; only the × control closes it.

Reproduction

1. Run PRKS in testing mode.
2. Open New File.
3. Press Tab so focus moves into the dialog (e.g. to Title).
4. Press Escape.

Deterministic in this pass (1/1).

Current behavior

The New File modal remains open with Title still focused after Escape. × closes the modal.

Expected / improved behavior

Escape dismisses a pristine New File modal (or follows the same unsaved/discard policy used elsewhere when dirty) and restores focus to the control that opened it.

User impact

Keyboard users cannot dismiss New File the standard way, inconsistent with common dialog patterns and with expectations set by other apps.

Evidence

• Tested commit: master@dc50f9b (dc50f9bb9a63007e739d9090b6284a8a467b43ef)
• Browser / viewport: Chromium auditor desktop
• Reproduction frequency: 1/1

Likely affected area

Hypothesis: New File / #work-modal keydown / dialog dismiss handling (not code-confirmed this pass).

Recommended direction

Wire Escape to the same close path as ×; if the form is dirty, reuse existing discard-confirmation patterns. Non-goal: changing the New File field set.

Acceptance criteria

• Escape closes a pristine New File modal.
• Focus returns to the opener after close.
• Dirty-state behavior matches other editors' unsaved policy.
• Regression coverage for Escape dismiss.

Existing issue / roadmap overlap

Checked ux-finding issues including #28 (New Person modal Escape/prefill). This finding is the New File modal specifically — related keyboard pattern, different dialog lifecycle. No existing issue covers New File Escape.

Assessment

• Priority: P2
• Areas: area:ux, area:correctness
• Change risk: low

This issue records a UX/UI finding for review. It does not authorize implementation.

---

Found using Grok Bot

[Fooftilly]

Verification: PASS on master@664cb8e (664cb8ebecdd953de18c1b014e55172ffe1f4049) after PR #131 merged (fix: shared modal Escape lifecycle).

Checked in live UI (python prks_app.py --testing, Chromium 1280×800, synthetic data)

• New File (pristine): Escape dismisses New File / work modal — PASS

Also: targeted E2E tests.e2e.test_modal_lifecycle — 3/3 PASS (not a full gate).

Did not change candidate / accepted labels.

---

Found using Grok Bot