Conversation
Move A→B→A cancel and private-ACK non-fence out of Chromium (already proven in Node/Python). Split stale-revision conflict: keep thin reconnect park, drop compact-body field asserts. Tip-clear pending/conflicts via wait_for_async. Co-authored-by: Nikola Perović <Fooftilly@users.noreply.github.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Continue the E2E KEEP / SPLIT / MOVE wave after Work Opens (#211) for the next high-value cancel/fence family: Work Notes.
What changes
1. Map (E2E → KEEP / SPLIT / MOVE → replacement)
coalescingFor(RESEARCH)A→B→A +mutationTestAtoBtoA; static mutation pinreconciliation()Private ACK must not fence Concepts/Arguments/GraphhandlerContract+ Python compact/stale conflict; thin Chromium keeps reconnect park2. Fast-layer gap check
Confirmed already present before removal — no new Node/Python scenarios required.
3. Retained browser boundaries (3 scenarios)
REVISION_CONFLICTand leaves peer body on the server4. Tip-clear
Retained
pending()/conflicts()now use harnesswait_for_async(same vacuous-risk fix as #204 / #211).5. Docs
docs/e2e-performance.mdrecords the Work-Notes map under §12. Does not restate the AGENTS.md KEEP/SPLIT/MOVE policy owned by #204.Expected impact
Removes 2 of 5 Work-Notes Chromium scenarios and narrows the conflict scenario; contracts remain in Node/Python.
Validation
node tests/browser/run_work_note_sync_selftest.js— 101 checks PASSpython3 -m unittest tests.test_frontend_work_note_sync tests.test_work_note_sync— PASSpython3 tests/e2e/run.py --jobs 2 --no-pointer-capture tests.e2e.test_work_notes_offline— 3 tests PASS--feature notes— 3 tests PASSscripts/e2e agent→ notes+work-detail, 111 tests): worker hang mid-suite on unrelated metadata path after ~4 min productive work; suspecttest_acknowledgement_patches_every_cached_representationPASSes alone (4.3s). Ambient/pre-existing under parallel affected blast; not caused by this Notes module change. Notes feature is the coherent affected substitute for the changed surface.python3 tests/e2e/run.py --jobs 4— 743 tests PASS in 842sNon-goals
Work Tags (#204), Work Source, Work Metadata, Work Opens (#211). Harness changes beyond tip-clear in this module. Folders / playlists / person-groups / browse / graph cache matrices.
Audit: Project store
internal/ws-other-offline-families.md§2; progressinternal/ws-work-notes-rationalization.md.