Update dependencies to patch known CVEs - #421
Closed
bauerpawel wants to merge 1 commit into
Closed
bauerpawel wants to merge 1 commit into
bauerpawel wants to merge 1 commit into
Conversation
govulncheck flagged golang.org/x/crypto (3 SSH DoS/auth CVEs) and golang.org/x/image (VP8L decode DoS) as required but unused by Gokapi's code paths; updated anyway as defense in depth. Also bumped go-oidc, modernc.org/sqlite, gopsutil, and miniredis to their latest patch releases while at it. golang.org/x/crypto v0.56.0 requires Go 1.26, so the go.mod language version was bumped accordingly (local toolchain and CI already exceed this). That surfaced a stricter vet printf check on three pre-existing non-constant format string calls in the test helper, fixed here. Remaining govulncheck findings (openpgp, aws-sdk-go S3 Crypto SDK) have no upstream fix and are not reachable from Gokapi's code. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019woTYJGrS4pfPWC6CCgffQ
Owner
|
Superseded by 4e75d67 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
govulncheckflaggedgolang.org/x/crypto(SSH DoS/auth CVEs) andgolang.org/x/image(VP8L decode DoS) as required-but-unused by any of Gokapi's reachable code paths. Updated them anyway as defense in depth, and picked up a few other patch-level bumps while going throughgo.mod:golang.org/x/cryptov0.54.0 → v0.56.0golang.org/x/imagev0.44.0 → v0.45.0github.com/coreos/go-oidc/v3v3.20.0 → v3.21.0modernc.org/sqlitev1.53.0 → v1.58.0 (+ transitivemodernc.org/libc,modernc.org/memory)github.com/shirou/gopsutil/v4v4.26.6 → v4.26.8github.com/alicebob/miniredis/v2v2.38.0 → v2.39.0golang.org/x/cryptov0.56.0 requires Go 1.26, so thego.modlanguage version was bumped accordingly. That surfaced a stricter vet printf check on three pre-existing non-constant format string calls in the test helper (internal/test/TestHelper.go), fixed here too.Two remaining
govulncheckfindings (openpgp, the AWS SDK S3 Crypto SDK) have no upstream fix available and are not reachable from Gokapi's code, so they're left as-is.Type of Change
Technical Details
govulncheck, applying the bumps, fixing the resulting vet errors). I reviewed and tested all changes before submitting.How Has This Been Tested?
go test ./... --tags=test,awsmock(full suite passes)Checklist
🤖 Generated with Claude Code