Fix reversed errors.Is() argument order in CLI uploader - #425
Merged
Merged
Conversation
errors.Is(err, target) expects the error being checked first and the sentinel second; these 6 calls had them swapped. Harmless today since none of the sentinels are themselves wrapped (so the initial equality check still matches either way), but fix for correctness and to avoid silently breaking if a sentinel ever gets wrapped. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019woTYJGrS4pfPWC6CCgffQ
Same bug as cliconfig.go: errors.Is(err, target) expects the error being checked first and the sentinel second; these calls had them swapped. Harmless today since the sentinel isn't itself wrapped, but fixed for correctness. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0168YUwGEzEHTqd9CwzXE53d
Owner
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
errors.Is(err, target)expects the error being checked first and the sentinel second; several calls in the CLI uploader (cmd/cli-uploader/Main.go,cmd/cli-uploader/cliconfig/cliconfig.go) had them swapped. Harmless today since none of the sentinels are themselves wrapped (so the initial equality check still matches either way), but fixed for correctness and to avoid silently breaking if a sentinel ever gets wrapped.Type of Change
Technical Details
How Has This Been Tested?
go test ./... --tags=test,awsmock(full suite passes;cmd/cli-uploaderhas no test files, this is a straightforward argument-order correction with no behavior change under current conditions)Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_0168YUwGEzEHTqd9CwzXE53d