Respect custom Docker mounts in setup warnings - #430
Merged
Merged
Conversation
Owner
|
Thank you very much! |
Contributor
Author
Anytime! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
The setup page checks only
/app/dataand/app/configwhen deciding whether Docker storage is persistent. CustomGOKAPI_DATA_DIRandGOKAPI_CONFIG_DIRvalues therefore trigger data-loss warnings even when those directories live under a mounted parent volume.Fixes #387
Changes
dataandconfigpaths by resolving them under/app.User impact
Docker deployments that place both directories below one custom volume no longer receive false data-loss warnings. Unmounted directories continue to warn.
Type of Change
Technical Details
How Has This Been Tested?
go test --tags=test,noaws ./internal/configuration/setup -run TestIsPathMounted -count=1— passed.go vet --tags=test,noaws ./internal/configuration/setup— passed.go build --tags=noaws ./...— passed.go generate ./...— passed with no generated diff.test,noawsandtest,awsmock) were attempted sequentially. The changed regression passes; the broader Windows run retains existing path-separator, open-file cleanup, setup-port timeout, and certificate-date failures. Representative path and setup-timeout failures reproduce on cleanorigin/master./proc/mountsinput covered through a deterministic parser test.Checklist