-
Notifications
You must be signed in to change notification settings - Fork 0
docs(workflows): MCP triggering — tools, flow and trigger settings (PRD-742) #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
christophebrun-forest
wants to merge
21
commits into
main
Choose a base branch
from
feature/prd-742-mcp-workflow-tools-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
0a79255
docs(workflows): MCP triggering — tools, flow and trigger settings (P…
christophebrun-forest 488139f
docs(workflows): align getWorkflowRun with the full hydrated run cont…
christophebrun-forest 17b6774
docs(workflows): address review — align MCP docs with the shipped con…
christophebrun-forest 4361f16
docs(workflows): fix end-step executionType and editor wording (PRD-742)
christophebrun-forest ec3b24d
docs(workflows): scope permission and audit claims to what the code e…
christophebrun-forest 0684448
docs(workflows): widen the human-step definition and hedge the inbox …
christophebrun-forest 9b2edd5
docs(workflows): correct the parked-run rule and the finished example…
christophebrun-forest 72b63a2
docs(workflows): align the runtime prerequisite with what is enforced…
christophebrun-forest 19fe126
docs(workflows): scope the audit claim and correct four MCP assertion…
christophebrun-forest 21bd095
docs(workflows): name the triggers screenshot for what it shows (PRD-…
christophebrun-forest 2d28e75
docs(workflows): correct six claims the implementation contradicts (P…
christophebrun-forest 712e294
docs(workflows): correct the runtime skew symptom (PRD-742)
christophebrun-forest cef6f8d
Merge origin/main into feature/prd-742-mcp-workflow-tools-docs
christophebrun-forest 84aaa8c
docs(workflows): scope the audit and permission guarantees to what th…
christophebrun-forest d48861a
docs(workflows): correct the trigger prerequisites and the runtime-sk…
christophebrun-forest f1f9319
docs(workflows): distinguish the two MCP trigger audit entries (PRD-742)
christophebrun-forest 45e0af6
docs(workflows): update the triggers screenshot (PRD-742)
christophebrun-forest 1b92740
docs(workflows): correct three claims the code does not support (PRD-…
christophebrun-forest 780bb07
docs(workflows): name the one field the projection does not filter (P…
christophebrun-forest 959778f
docs(reference): complete the MCP tool name list (PRD-742)
christophebrun-forest fa79cfd
docs(workflows): correct four claims the code does not support (PRD-742)
christophebrun-forest File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bullet lands directly above "Every operation runs with the permissions of the authenticated Forest user and is logged just like a UI action" — and for the two read-only workflow tools, the second half is not true.
listWorkflowsandgetWorkflowRunwrite no activity log (unlikelist,listRelated,describeCollection, which all do). OnlytriggerWorkflowis audited. So of the three tools this bullet introduces, one is logged and two are not.Either the tools gain audit logging (raised on ForestAdmin/agent-nodejs#1792) or this page needs a qualifier — "every state-changing operation" would already be accurate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in
ec3b24dwith your qualifier — the sentence now reads "every state-changing operation is logged just like a UI action", which is exactly what the code enforces. Auditing the two read tools needs server-side support (the MCP activity-log route silently drops resource-less logs), tracked in PRD-967; when that lands this sentence can be strengthened back.