Skip to content

chore: update lint baselines #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fossifybot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: update lint baselines #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions app/detekt-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,7 @@
<SmellBaseline>
<ManuallySuppressedIssues/>
<CurrentIssues>
<ID>ComplexCondition:MainActivity.kt$MainActivity$requestCode == PICK_IMAGE_INTENT &amp;&amp; resultCode == Activity.RESULT_OK &amp;&amp; resultData != null &amp;&amp; resultData.data != null</ID>
<ID>ComplexCondition:MainActivity.kt$MainActivity$requestCode == SAVE_IMAGE_INTENT &amp;&amp; resultCode == Activity.RESULT_OK &amp;&amp; resultData != null &amp;&amp; resultData.data != null</ID>
<ID>ComplexCondition:MyCanvas.kt$MyCanvas$!mIsBucketFillOn &amp;&amp; (!mAllowMovingZooming || (!mScaleDetector!!.isInProgress &amp;&amp; event.pointerCount == 1 &amp;&amp; !mWasMultitouch))</ID>
<ID>ConstructorParameterNaming:VectorFloodFiller.kt$VectorFloodFiller.FloodFillRange$var Y: Int</ID>
<ID>CyclomaticComplexMethod:MyCanvas.kt$MyCanvas$override fun onTouchEvent(event: MotionEvent): Boolean</ID>
<ID>EmptyCatchBlock:MainActivity.kt$MainActivity${ }</ID>
<ID>LargeClass:MainActivity.kt$MainActivity : SimpleActivityCanvasListener</ID>
Expand All @@ -18,32 +15,18 @@
<ID>MagicNumber:MyCanvas.kt$MyCanvas$100f</ID>
<ID>MagicNumber:MyCanvas.kt$MyCanvas.ScaleListener$0.1f</ID>
<ID>MagicNumber:MyCanvas.kt$MyCanvas.ScaleListener$10.0f</ID>
<ID>MagicNumber:VectorFloodFiller.kt$VectorFloodFiller$0xff</ID>
<ID>MagicNumber:VectorFloodFiller.kt$VectorFloodFiller$16</ID>
<ID>MagicNumber:VectorFloodFiller.kt$VectorFloodFiller$8</ID>
<ID>MaxLineLength:MainActivity.kt$MainActivity$if</ID>
<ID>MaxLineLength:MainActivity.kt$MainActivity$}</ID>
<ID>MaxLineLength:MyCanvas.kt$MyCanvas$if</ID>
<ID>MaxLineLength:SettingsActivity.kt$SettingsActivity$settingsUseEnglishHolder.beVisibleIf((config.wasUseEnglishToggled || Locale.getDefault().language != "en") &amp;&amp; !isTiramisuPlus())</ID>
<ID>MaxLineLength:VectorFloodFiller.kt$VectorFloodFiller$// if we're not below the bottom of the bitmap and the pixel below this one is within the color tolerance</ID>
<ID>MaxLineLength:VectorFloodFiller.kt$VectorFloodFiller$return red &gt;= startColorRed - tolerance &amp;&amp; red &lt;= startColorRed + tolerance &amp;&amp; green &gt;= startColorGreen - tolerance &amp;&amp; green &lt;= startColorGreen + tolerance &amp;&amp; blue &gt;= startColorBlue - tolerance &amp;&amp; blue &lt;= startColorBlue + tolerance</ID>
<ID>NestedBlockDepth:MyPath.kt$MyPath$fun readObject(pathData: String, activity: Activity)</ID>
<ID>SerialVersionUIDInSerializableClass:MyPath.kt$MyPath : PathSerializable</ID>
<ID>SerialVersionUIDInSerializableClass:Svg.kt$Svg$SPath : Serializable</ID>
<ID>SerialVersionUIDInSerializableClass:Svg.kt$Svg$SRect : Serializable</ID>
<ID>SerialVersionUIDInSerializableClass:Svg.kt$Svg$SSvg : Serializable</ID>
<ID>SwallowedException:MainActivity.kt$MainActivity$e: ActivityNotFoundException</ID>
<ID>SwallowedException:MainActivity.kt$MainActivity$e: Exception</ID>
<ID>SwallowedException:MyCanvas.kt$MyCanvas$e: Exception</ID>
<ID>SwallowedException:MyCanvas.kt$MyCanvas$e: ExecutionException</ID>
<ID>SwallowedException:MyPath.kt$MyPath$e: Exception</ID>
<ID>TooGenericExceptionCaught:MainActivity.kt$MainActivity$e: Exception</ID>
<ID>TooGenericExceptionCaught:MyCanvas.kt$MyCanvas$e: Exception</ID>
<ID>TooGenericExceptionCaught:MyPath.kt$MyPath$e: Exception</ID>
<ID>TooManyFunctions:MainActivity.kt$MainActivity : SimpleActivityCanvasListener</ID>
<ID>TooManyFunctions:MyCanvas.kt$MyCanvas : View</ID>
<ID>UnusedPrivateMember:MyPath.kt$MyPath$private fun readObject(inputStream: ObjectInputStream)</ID>
<ID>VariableNaming:MyCanvas.kt$MyCanvas$private val FLOOD_FILL_TOLERANCE = 1</ID>
<ID>VariableNaming:MyCanvas.kt$MyCanvas$private val MAX_HISTORY_COUNT = 1000</ID>
<ID>VariableNaming:SaveImageDialog.kt$SaveImageDialog$private val SIMPLE_DRAW = "Fossify Paint"</ID>
</CurrentIssues>
Expand Down
66 changes: 33 additions & 33 deletions app/lint-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
errorLine2=" ~~~~">
<location
file="$HOME/work/Paint/Paint/gradle/libs.versions.toml"
line="15"
line="20"
column="23"/>
</issue>

Expand All @@ -43,13 +43,13 @@

<issue
id="AndroidGradlePluginVersion"
message="A newer version of Gradle than 9.7.1 is available: 9.8.0"
errorLine1="distributionUrl=https\://services.gradle.org/distributions/gradle-9.7.1-bin.zip"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
message="A newer version of com.android.application than 9.4.1 is available: 9.5.0"
errorLine1="gradlePlugins-agp = &quot;9.4.1&quot;"
errorLine2=" ~~~~~~~">
<location
file="$HOME/work/Paint/Paint/gradle/wrapper/gradle-wrapper.properties"
line="3"
column="17"/>
file="$HOME/work/Paint/Paint/gradle/libs.versions.toml"
line="17"
column="21"/>
</issue>

<issue
Expand All @@ -59,24 +59,24 @@
errorLine2=" ~~~~">
<location
file="$HOME/work/Paint/Paint/gradle/libs.versions.toml"
line="14"
line="19"
column="31"/>
</issue>

<issue
id="NewerVersionAvailable"
message="A newer version of io.nlopez.compose.rules:detekt than 0.4.28 is available: 0.6.7"
message="A newer version of io.nlopez.compose.rules:detekt than 0.4.28 is available: 0.6.8"
errorLine1="detektCompose = &quot;0.4.28&quot;"
errorLine2=" ~~~~~~~~">
<location
file="$HOME/work/Paint/Paint/gradle/libs.versions.toml"
line="6"
line="11"
column="17"/>
</issue>

<issue
id="MissingTranslation"
message="&quot;app_launcher_name&quot; is not translated in &quot;fil&quot; (Filipino; Pilipino), &quot;lt&quot; (Lithuanian), &quot;ia&quot; (Interlingua), &quot;ml&quot; (Malayalam), &quot;ms&quot; (Malay), &quot;is&quot; (Icelandic), &quot;my&quot; (Burmese), &quot;vi&quot; (Vietnamese), &quot;nb&quot; (Norwegian Bokmål), &quot;ne&quot; (Nepali), &quot;ro&quot; (Romanian), &quot;nn&quot; (Norwegian Nynorsk), &quot;bn&quot; (Bangla), &quot;kab&quot; (Kabyle), &quot;br&quot; (Breton), &quot;bs&quot; (Bosnian), &quot;si&quot; (Sinhala), &quot;sl&quot; (Slovenian), &quot;zgh&quot; (Standard Moroccan Tamazight), &quot;ltg&quot;, &quot;kn&quot; (Kannada), &quot;or&quot; (Odia), &quot;kr&quot; (Kanuri), &quot;sat&quot; (Santali), &quot;ta&quot; (Tamil), &quot;cr&quot; (Cree), &quot;pa&quot; (Punjabi), &quot;te&quot; (Telugu), &quot;cy&quot; (Welsh)"
message="&quot;app_launcher_name&quot; is not translated in &quot;fil&quot; (Filipino; Pilipino), &quot;lt&quot; (Lithuanian), &quot;ia&quot; (Interlingua), &quot;ml&quot; (Malayalam), &quot;ms&quot; (Malay), &quot;is&quot; (Icelandic), &quot;my&quot; (Burmese), &quot;vi&quot; (Vietnamese), &quot;nb&quot; (Norwegian Bokmål), &quot;ne&quot; (Nepali), &quot;ro&quot; (Romanian), &quot;nn&quot; (Norwegian Nynorsk), &quot;bn&quot; (Bangla), &quot;kab&quot; (Kabyle), &quot;br&quot; (Breton), &quot;bs&quot; (Bosnian), &quot;si&quot; (Sinhala), &quot;zgh&quot; (Standard Moroccan Tamazight), &quot;ltg&quot;, &quot;kn&quot; (Kannada), &quot;or&quot; (Odia), &quot;kr&quot; (Kanuri), &quot;sat&quot; (Santali), &quot;ta&quot; (Tamil), &quot;cr&quot; (Cree), &quot;pa&quot; (Punjabi), &quot;te&quot; (Telugu), &quot;cy&quot; (Welsh)"
errorLine1=" &lt;string name=&quot;app_launcher_name&quot;>Paint_debug&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
Expand All @@ -87,7 +87,7 @@

<issue
id="MissingTranslation"
message="&quot;app_launcher_name&quot; is not translated in &quot;fil&quot; (Filipino; Pilipino), &quot;lt&quot; (Lithuanian), &quot;ia&quot; (Interlingua), &quot;ml&quot; (Malayalam), &quot;ms&quot; (Malay), &quot;is&quot; (Icelandic), &quot;my&quot; (Burmese), &quot;vi&quot; (Vietnamese), &quot;nb&quot; (Norwegian Bokmål), &quot;ne&quot; (Nepali), &quot;ro&quot; (Romanian), &quot;nn&quot; (Norwegian Nynorsk), &quot;bn&quot; (Bangla), &quot;kab&quot; (Kabyle), &quot;br&quot; (Breton), &quot;bs&quot; (Bosnian), &quot;si&quot; (Sinhala), &quot;sl&quot; (Slovenian), &quot;zgh&quot; (Standard Moroccan Tamazight), &quot;ltg&quot;, &quot;kn&quot; (Kannada), &quot;or&quot; (Odia), &quot;kr&quot; (Kanuri), &quot;sat&quot; (Santali), &quot;ta&quot; (Tamil), &quot;cr&quot; (Cree), &quot;pa&quot; (Punjabi), &quot;te&quot; (Telugu), &quot;cy&quot; (Welsh)"
message="&quot;app_launcher_name&quot; is not translated in &quot;fil&quot; (Filipino; Pilipino), &quot;lt&quot; (Lithuanian), &quot;ia&quot; (Interlingua), &quot;ml&quot; (Malayalam), &quot;ms&quot; (Malay), &quot;is&quot; (Icelandic), &quot;my&quot; (Burmese), &quot;vi&quot; (Vietnamese), &quot;nb&quot; (Norwegian Bokmål), &quot;ne&quot; (Nepali), &quot;ro&quot; (Romanian), &quot;nn&quot; (Norwegian Nynorsk), &quot;bn&quot; (Bangla), &quot;kab&quot; (Kabyle), &quot;br&quot; (Breton), &quot;bs&quot; (Bosnian), &quot;si&quot; (Sinhala), &quot;zgh&quot; (Standard Moroccan Tamazight), &quot;ltg&quot;, &quot;kn&quot; (Kannada), &quot;or&quot; (Odia), &quot;kr&quot; (Kanuri), &quot;sat&quot; (Santali), &quot;ta&quot; (Tamil), &quot;cr&quot; (Cree), &quot;pa&quot; (Punjabi), &quot;te&quot; (Telugu), &quot;cy&quot; (Welsh)"
errorLine1=" &lt;string name=&quot;app_launcher_name&quot;>Paint&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
Expand All @@ -98,7 +98,7 @@

<issue
id="MissingTranslation"
message="&quot;open_file&quot; is not translated in &quot;ms&quot; (Malay), &quot;is&quot; (Icelandic), &quot;my&quot; (Burmese), &quot;ne&quot; (Nepali), &quot;nn&quot; (Norwegian Nynorsk), &quot;bn&quot; (Bangla), &quot;br&quot; (Breton), &quot;bs&quot; (Bosnian), &quot;si&quot; (Sinhala), &quot;zgh&quot; (Standard Moroccan Tamazight), &quot;ltg&quot;, &quot;kn&quot; (Kannada), &quot;or&quot; (Odia), &quot;kr&quot; (Kanuri), &quot;sat&quot; (Santali), &quot;ta&quot; (Tamil), &quot;cr&quot; (Cree), &quot;te&quot; (Telugu)"
message="&quot;open_file&quot; is not translated in &quot;ms&quot; (Malay), &quot;is&quot; (Icelandic), &quot;my&quot; (Burmese), &quot;ne&quot; (Nepali), &quot;nn&quot; (Norwegian Nynorsk), &quot;bn&quot; (Bangla), &quot;br&quot; (Breton), &quot;bs&quot; (Bosnian), &quot;si&quot; (Sinhala), &quot;zgh&quot; (Standard Moroccan Tamazight), &quot;ltg&quot;, &quot;kn&quot; (Kannada), &quot;or&quot; (Odia), &quot;kr&quot; (Kanuri), &quot;sat&quot; (Santali), &quot;cr&quot; (Cree), &quot;te&quot; (Telugu)"
errorLine1=" &lt;string name=&quot;open_file&quot;>Open file&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~">
<location
Expand Down Expand Up @@ -153,7 +153,7 @@

<issue
id="MissingTranslation"
message="&quot;clear_canvas_confirmation&quot; is not translated in &quot;hi&quot; (Hindi), &quot;fil&quot; (Filipino; Pilipino), &quot;lt&quot; (Lithuanian), &quot;ia&quot; (Interlingua), &quot;mk&quot; (Macedonian), &quot;ml&quot; (Malayalam), &quot;in&quot; (Indonesian), &quot;ms&quot; (Malay), &quot;is&quot; (Icelandic), &quot;my&quot; (Burmese), &quot;vi&quot; (Vietnamese), &quot;ne&quot; (Nepali), &quot;az&quot; (Azerbaijani), &quot;ro&quot; (Romanian), &quot;nn&quot; (Norwegian Nynorsk), &quot;bn&quot; (Bangla), &quot;kab&quot; (Kabyle), &quot;br&quot; (Breton), &quot;bs&quot; (Bosnian), &quot;si&quot; (Sinhala), &quot;sl&quot; (Slovenian), &quot;zgh&quot; (Standard Moroccan Tamazight), &quot;ltg&quot;, &quot;sr&quot; (Serbian), &quot;kn&quot; (Kannada), &quot;or&quot; (Odia), &quot;kr&quot; (Kanuri), &quot;sat&quot; (Santali), &quot;ta&quot; (Tamil), &quot;cr&quot; (Cree), &quot;pa&quot; (Punjabi), &quot;te&quot; (Telugu), &quot;cy&quot; (Welsh), &quot;bqi&quot;, &quot;ckb&quot;"
message="&quot;clear_canvas_confirmation&quot; is not translated in &quot;hi&quot; (Hindi), &quot;fil&quot; (Filipino; Pilipino), &quot;lt&quot; (Lithuanian), &quot;ia&quot; (Interlingua), &quot;mk&quot; (Macedonian), &quot;ml&quot; (Malayalam), &quot;in&quot; (Indonesian), &quot;ms&quot; (Malay), &quot;is&quot; (Icelandic), &quot;my&quot; (Burmese), &quot;vi&quot; (Vietnamese), &quot;ne&quot; (Nepali), &quot;az&quot; (Azerbaijani), &quot;ro&quot; (Romanian), &quot;nn&quot; (Norwegian Nynorsk), &quot;bn&quot; (Bangla), &quot;kab&quot; (Kabyle), &quot;br&quot; (Breton), &quot;bs&quot; (Bosnian), &quot;si&quot; (Sinhala), &quot;zgh&quot; (Standard Moroccan Tamazight), &quot;ltg&quot;, &quot;sr&quot; (Serbian), &quot;kn&quot; (Kannada), &quot;or&quot; (Odia), &quot;kr&quot; (Kanuri), &quot;sat&quot; (Santali), &quot;ta&quot; (Tamil), &quot;cr&quot; (Cree), &quot;pa&quot; (Punjabi), &quot;te&quot; (Telugu), &quot;cy&quot; (Welsh), &quot;bqi&quot;, &quot;ckb&quot;"
errorLine1=" &lt;string name=&quot;clear_canvas_confirmation&quot;>Are you sure you want to clear the canvas?&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
Expand Down Expand Up @@ -186,7 +186,7 @@

<issue
id="MissingTranslation"
message="&quot;use_relative_brush_size&quot; is not translated in &quot;fil&quot; (Filipino; Pilipino), &quot;lt&quot; (Lithuanian), &quot;ia&quot; (Interlingua), &quot;mk&quot; (Macedonian), &quot;ml&quot; (Malayalam), &quot;in&quot; (Indonesian), &quot;ms&quot; (Malay), &quot;is&quot; (Icelandic), &quot;my&quot; (Burmese), &quot;vi&quot; (Vietnamese), &quot;ne&quot; (Nepali), &quot;az&quot; (Azerbaijani), &quot;ro&quot; (Romanian), &quot;nn&quot; (Norwegian Nynorsk), &quot;bn&quot; (Bangla), &quot;kab&quot; (Kabyle), &quot;br&quot; (Breton), &quot;bs&quot; (Bosnian), &quot;si&quot; (Sinhala), &quot;sl&quot; (Slovenian), &quot;zgh&quot; (Standard Moroccan Tamazight), &quot;ltg&quot;, &quot;kn&quot; (Kannada), &quot;or&quot; (Odia), &quot;kr&quot; (Kanuri), &quot;sat&quot; (Santali), &quot;ta&quot; (Tamil), &quot;cr&quot; (Cree), &quot;pa&quot; (Punjabi), &quot;te&quot; (Telugu), &quot;cy&quot; (Welsh), &quot;bqi&quot;, &quot;ckb&quot;"
message="&quot;use_relative_brush_size&quot; is not translated in &quot;fil&quot; (Filipino; Pilipino), &quot;lt&quot; (Lithuanian), &quot;ia&quot; (Interlingua), &quot;mk&quot; (Macedonian), &quot;ml&quot; (Malayalam), &quot;in&quot; (Indonesian), &quot;ms&quot; (Malay), &quot;is&quot; (Icelandic), &quot;my&quot; (Burmese), &quot;vi&quot; (Vietnamese), &quot;ne&quot; (Nepali), &quot;az&quot; (Azerbaijani), &quot;ro&quot; (Romanian), &quot;nn&quot; (Norwegian Nynorsk), &quot;bn&quot; (Bangla), &quot;kab&quot; (Kabyle), &quot;br&quot; (Breton), &quot;bs&quot; (Bosnian), &quot;si&quot; (Sinhala), &quot;zgh&quot; (Standard Moroccan Tamazight), &quot;ltg&quot;, &quot;kn&quot; (Kannada), &quot;or&quot; (Odia), &quot;kr&quot; (Kanuri), &quot;sat&quot; (Santali), &quot;ta&quot; (Tamil), &quot;cr&quot; (Cree), &quot;pa&quot; (Punjabi), &quot;te&quot; (Telugu), &quot;cy&quot; (Welsh), &quot;bqi&quot;, &quot;ckb&quot;"
errorLine1=" &lt;string name=&quot;use_relative_brush_size&quot;>Adjust brush size based on zoom level&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
Expand Down Expand Up @@ -224,6 +224,17 @@
file="src/main/res/mipmap-anydpi-v26"/>
</issue>

<issue
id="UnusedResources"
message="The resource `R.bool.show_donate_in_about` appears to be unused"
errorLine1=" &lt;bool name=&quot;show_donate_in_about&quot;>true&lt;/bool>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/foss/res/values/bools.xml"
line="3"
column="11"/>
</issue>

<issue
id="UnusedResources"
message="The resource `R.string.package_name` appears to be unused"
Expand Down Expand Up @@ -370,24 +381,13 @@

<issue
id="UseKtx"
message="Use the KTX extension function `Canvas.withSave` instead?"
errorLine1=" canvas.save()"
errorLine2=" ~~~~~~~~~~~~~">
<location
file="src/main/kotlin/org/fossify/paint/views/MyCanvas.kt"
line="219"
column="9"/>
</issue>

<issue
id="UseKtx"
message="Use the KTX function `createBitmap` instead?"
errorLine1=" val bitmap = Bitmap.createBitmap(width, height, Bitmap.Config.ARGB_8888)"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
message="Use the KTX extension function `String.toColorInt` instead?"
errorLine1=" val color = if (isEraser) 0 else Color.parseColor(if (isFill) fill else stroke)"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/kotlin/org/fossify/paint/views/MyCanvas.kt"
line="315"
column="22"/>
file="src/main/kotlin/org/fossify/paint/models/Svg.kt"
line="221"
column="38"/>
</issue>

<issue
Expand All @@ -408,7 +408,7 @@
errorLine2=" ~~~~~~~~~~~~">
<location
file="src/main/kotlin/org/fossify/paint/views/MyCanvas.kt"
line="113"
line="142"
column="18"/>
</issue>

Expand Down
Loading