Load certificate's subject/DN from config file or CLI - #508
Open
Fahrj wants to merge 2 commits into
Open
Conversation
This might change behavior of `RotateKeyWithBackend` since `backend` is no longer used!
Instead of `description`, load and parse `subject` for all key types. Format follows openssl fashion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following openssl's style, e.g. /CN=Platform Key/C=WW/, a custom distinguished name can be given on the CLI of
sbctl create-keys, or alternatively in the config file.Probably a breaking change, because the PR replaces
descriptionwithsubjectin the config, which however was not yet documented.Sliced from #474 and initially authored by @bsingh-kpt
Closes #362