Establish safe Niriland phase one foundation - #2
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 882d3e5152
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| printf 'Package sets: %s\n' "$package_sets" | ||
| printf 'State root: %s%s\n' "$state_root" \ | ||
| "$([[ -d "$state_root" ]] && printf ' (present)' || printf ' (not created)')" | ||
| printf 'Discovered migrations: %d\n' "${#NIRILAND_MIGRATION_IDS[@]}" |
There was a problem hiding this comment.
Report receipt states in status
When migration receipts exist—especially invalid or source-mismatched ones—status only reports the number of discovered scripts and never calls niriland_migration_receipt_status, so it produces identical output for pending, completed, and blocked receipt states. This contradicts the documented status receipt overview in plan.md:235 and hides migration-state problems unless the user separately runs plan; summarize each receipt state here rather than only counting migration files.
Useful? React with 👍 / 👎.
Summary
niriland planandniriland statusmachine.local.conf, validate the selected profile, and require confirmation before installationbin/, private command code undersrc/niriland/, and the active fresh-install flow underinstaller/configs/base/andconfigs/modules/with the explicitconfigs/home/,configs/shared/, andconfigs/system/ownership modelValidation
niriland plan,plan --prune, andstatuspassed without mutationSafety
No installer, package transaction, sudo command, service mutation, migration apply, live config deployment, reboot, suspend, or hibernation action was run. Mutating commands in the new CLI remain explicitly disabled for Phase 1. The active installer is preserved under
installer/untilniriland applycan replace it without removing fresh-install support.