Skip to content

chore(appearance): sync create-bitfun-skin contract - #2386

Open
kev1n77 wants to merge 1 commit into
GCWing:mainfrom
kev1n77:fmy/dev
Open

chore(appearance): sync create-bitfun-skin contract#2386
kev1n77 wants to merge 1 commit into
GCWing:mainfrom
kev1n77:fmy/dev

Conversation

@kev1n77

@kev1n77 kev1n77 commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Sync the bundled create-bitfun-skin skill with the current BitFun Appearance contract.
  • Refresh the registry snapshot to 255 components, 19 scenes, and 6 renderer adapters.
  • Make registry checks compare contract content instead of provenance-only revisions.
  • Add regression coverage for registry comparison and cinematic surface-plan provenance.

Fixes #

Type and Areas

Type:

Bug fix / docs / test

Areas:

Rust core built-in Agent skills, Web UI Appearance contract, developer tooling

Motivation / Impact

The bundled skin-authoring skill had an outdated Appearance registry. It could not discover newly registered surfaces and could accept owners that have since been removed.

Registry synchronization also compared the BitFun checkout commit directly, causing unrelated commits to report a false contract mismatch. The updated check compares exported contract content while retaining revision metadata for provenance.

Existing Appearance packages remain compatible. Twelve existing example skins were verified against the current production Validator and Compiler with no errors or warnings.

Verification

  • python <skill-creator>/scripts/quick_validate.py <create-bitfun-skin-path>
    • Passed for both the standalone and bundled skill.
  • python -B scripts/test_bitfun_appearance.py
    • 6 tests passed.
  • python -B scripts/test_cinematic_tools.py
    • 6 tests passed, including the complete build/check pipeline.
  • python scripts/sync_registry.py <bitfun-repo> --check
    • Passed from a clean checkout after the commit, despite the provenance revision differing from the new repository HEAD.
  • cargo test -p bitfun-core --no-default-features --features agent-runtime --lib create_bitfun_skin_embeds_authoring_contract_and_example
    • 1 test passed; 1,415 tests filtered out.
    • Existing unrelated unused-import warnings remain.
  • git diff --check
    • Passed.
  • Batch host verification of 12 existing .bitfun-appearance examples:
    • 12/12 accepted by the current production Validator and Compiler.
    • No errors or warnings.

Remote workspace, remote control, Peer Device Mode, and Detached Dispatch were not exercised because this change only updates bundled skill content and offline authoring validation.

Reviewer Notes

  • The registry snapshot records the clean source revision from which the Appearance contract was exported.
  • The snapshot revision is intentionally not required to equal the commit containing the generated file. --check now detects actual contract drift rather than unrelated repository commits.
  • No package schema, persisted data, runtime behavior, or migration contract changed.
  • Existing skins do not need rebuilding or version bumps solely because of this registry refresh.

Checklist

  • This PR is focused and does not include secrets, temporary prompts, generated scratch files, or unrelated artifacts.
  • Relevant verification is recorded above, or skipped checks are explained.
  • User-facing strings, docs, and locales are updated where applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant