fix(web): follow the agents scene part rename in the compiler test - #2394
Merged
wgqqqqq merged 1 commit intoAug 20, 2026
Merged
Conversation
`bdbc6cb53` restructured the agents scene's part list, replacing `anchorBar`, `harnessGrid` and `coreGrid` with `harnessPresentation` and `catalogGrid`. `AppearanceCompiler.test.ts` still authored its package against `coreGrid`, so the validator rejected the part and `compile` threw before a single assertion ran. `pnpm --dir src/web-ui run test:run` has failed on `1.0.0-explore` ever since, which is the Frontend Build job. What the case is actually about is that a scene part reaches the compiled selector, not which part it happens to be, so it moves to `catalogGrid` -- the name the scene and `AgentsScene.tsx` now render -- rather than the descriptor regaining a part nothing draws. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is broken
Frontend Buildhas been red on1.0.0-exploresince bdbc6cb, and the failure is in the test rather than in the product:That commit restructured the agents scene's part list --
anchorBar,harnessGridandcoreGridgave way toharnessPresentationandcatalogGrid, andAgentsScene.tsxmoved todata-bf-part="catalogGrid"with it.AppearanceCompiler.test.tswas not carried along: it still authors its package againstcoreGrid, so the validator rejects the part andcompilethrows before a single assertion in the case runs.The fix
Two occurrences renamed to
catalogGrid. The case is about a scene part reaching the compiled selector, not about which part it happens to be, so it follows the scene rather than the descriptor regaining a part nothing draws.Not included
src/crates/assembly/core/builtin_skills/create-bitfun-skin/references/appearance-registry.jsonstill carries the pre-renamecoreGridtoo. Nothing in CI validates that snapshot,SKILL.mdsays not to hand-edit it, andscripts/sync_registry.pyis what regenerates it -- so it is left for whoever owns that skill.Verification
1.0.0-explorecheckout:1 failed | 14 passed15 passedpnpm --dir src/web-ui run test:run: 523 files, 3835 tests, 0 failurespnpm run lint:web: clean