fix(ai): preserve reasoning projection when applying presets - #2401
Merged
Conversation
Keep the resolved reasoning projection and its catalog binding together with the model draft when applying reasoning preset changes. Reuse the matching projection for summaries, subsequent edits, and save validation so models.dev defaults are not rejected as unknown presets. Extend the reasoning panel test to cover applying an updated models.dev projection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the resolved reasoning projection and its catalog binding together
with the model draft when applying reasoning preset changes.
Reuse the matching projection for summaries, subsequent edits, and save
validation so models.dev defaults are not rejected as unknown presets.
Extend the reasoning panel test to cover applying an updated models.dev
projection.