Repository navigation
Fix: call fv_setup from Initialize instead of SetServices in AdvCore - #422
Merged
pchakraborty merged 4 commits intoOct 28, 2026
Merged
Conversation
fv_setup requests num_levels via MAPL_GridCompGet, which is only populated once the vertical grid is initialized during the GENERIC_INIT_GEOM_A phase. Since SetServices runs before that phase, num_levels silently defaulted to 1, breaking standalone AdvCore runs (no DynCore) as reported in #420. Move the fv_setup call to Initialize, mirroring the existing pattern in DynCore_GridCompMod, so num_levels is resolved correctly. Fixes #420
pchakraborty
added
the
0 diff
Collaborator
Author
|
Closing it in favor of the workaround that @lizziel has. |
Collaborator
Author
|
Ref: #432 (comment) |
mathomp4
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fv_setuprequestsnum_levelsviaMAPL_GridCompGet, which is only populated once the vertical grid is initialized during theGENERIC_INIT_GEOM_Aphase. SinceSetServicesruns before that phase,num_levelssilently defaulted to 1, breaking standalone AdvCore runs (no DynCore).Moves the
fv_setupcall toInitialize, mirroring the existing pattern already used inDynCore_GridCompMod, sonum_levelsis resolved correctly.Fixes #420
@lizziel