Repository navigation
Add adv-sa regression test for standalone AdvCore - #437
Open
pchakraborty wants to merge 1 commit into
Open
pchakraborty wants to merge 1 commit into
pchakraborty wants to merge 1 commit into
Conversation
AdvCore runs without DynCore (DYCORE unset), so it does its own fv_setup. MFX/MFY/CX/CY/PLE0/PLE1 come from a DataForAdv internal restart, which is the adv-dyn baseline's DYN_export.nc. run_case.cmake now calls copy_restarts so cases can stage input restarts from the regression data. Also update the vertical_grid config in adv-dyn and dyn-sa to the current MAPL syntax (grid_type/fields).
pchakraborty
marked this pull request as ready for review
October 29, 2026 12:54
pchakraborty
added
0 diff
|
This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
adv-sa, a regression case that runs AdvCore on its own (no DynCore),the configuration used by GCHP (#420).
regression/adv-sa/: ADV + DataForAdv (provides MFX, MFY, CX, CY, PLE0, PLE1 from its internal restart) + DataTracers (Q001, Q002 via TRADV). C12, 91 levels, 6 PEs, two 30-min steps; baseline is ADV's export checkpoint.adv.yamlhasgeometryboth top-level and undermapl:(YAML anchor): MAPL needs it undermapl:before connections are made (AdvCore only calls MAPL_GridCompSetGeometry in Initialize, i.e. INIT_USER), and fv_setup reads it from the top level.run_case.cmake: callscopy_restartsbefore running (no-op for the cold-start cases adv-dyn and dyn-sa).adv-dyn/dyn.yaml,dyn-sa/dyn-sa.yaml:vertical_gridupdated to the current MAPL syntax (grid_type: model,fields: {pressure: PLE}).cases.txt,README.mdupdated.Regression data (
FVdycoreCubed_GridComp/adv-sa/):checkpoints/1891-03-02T00:00:00/DataForAdv_internal.nc: symlink to../../../adv-dyn/checkpoints/last/DYN_export.nccheckpoints/last/ADV_export.nc: baselineThe data still has to be uploaded to /ford1 and S3; until then
adv-safails (missing input restart).Testing
ctest -R '^adv-sa$'(ifx Debug,LOCAL_REGRESSION_DATA_DIRpointing at a local copy of the data) passed; baseline comparison skipped since the baseline didn't exist yet.ADV_export.nc(nccmp).vertical_gridsyntax as part of this PR.