Skip to content

test: exercise panel database and encryption-key recovery - #770

Open
Baylem wants to merge 7 commits into
GameplanePanel:masterfrom
Baylem:fix/audit-recovery-drill
Open

Baylem wants to merge 7 commits into
GameplanePanel:masterfrom
Baylem:fix/audit-recovery-drill

Conversation

@Baylem

@Baylem Baylem commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Panel database recovery needs to preserve live games, restored authorization and the encryption key paired with the backup. This adds a recovery runbook for combined and standalone deployments and an isolated SQLite recovery drill in CI.

The drill backs up a private standalone panel, destroys its working database, restores a copy, invalidates old bearer credentials and checks users, scoped permissions, encrypted cluster registration, audit integrity and continued game progress. A wrong-key startup must exit without serving HTTP; the probe has a positive control. A sanitized CI artifact records actual recovery-point age and recovery time, including the wrong-key trial. The original archive remains read-only.

The runbook covers database outage/loss, lost keys, Kubernetes/SQL identity reconciliation and operator-selected targets. PostgreSQL PITR and complete storage-cluster recovery remain deployment-specific procedures.

Validation: E2E Go source and Python compilation passed; actionlint, offline zizmor and whitespace checks passed. Runtime tests and measured recovery results are pending CI, per the repository's compile-only local policy.

Includes the shared web build prerequisite from #759 so full CI can build the existing UI.

Includes the shared NuclearOption agent correction also present in #771: one absolute deadline covers dialing, request writes and response reads, and a stalled partial request closes the connection. Regression sources cover blocked length and body writes; the original closed-response assertion is preserved.

Closes #728.

The recovery drill waits for a registered cluster to become usable before assigning its scoped grant, then separately verifies reader access. Its template update changes only the intended command, avoiding conflicts with controller status updates.

Signed-off-by: Baylem <zelathis@gmail.com>
Signed-off-by: Baylem <zelathis@gmail.com>
Signed-off-by: Baylem <zelathis@gmail.com>
Signed-off-by: Baylem <zelathis@gmail.com>
@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 57 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: GameplanePanel/Gameplane/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 321b16c3-9bae-4bbc-a00f-3b0d2a5cb31b
📥 Commits

Reviewing files that changed from the base of the PR and between df1e371 and 56ba591.

📒 Files selected for processing: 15
  • .github/workflows/ci.yaml
  • agent/internal/rcon/nuclearoption.go
  • agent/internal/rcon/nuclearoption_deadline_test.go
  • agent/internal/rcon/nuclearoption_test.go
  • agent/specs.md
  • docs/panel-recovery.md
  • docs/standalone-panel.md
  • test/e2e/api_auth_e2e_test.go
  • test/e2e/api_session_e2e_test.go
  • test/e2e/buckets.sh
  • test/e2e/env.go
  • test/e2e/panel_recovery_e2e_test.go
  • test/e2e/specs.md
  • test/e2e/testdata/recovery/maintenance.py
  • web/src/routes/CreateServer.tsx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added area: e2e kind-based end-to-end suite area: shared netguard, gameaction, gameproto, svcutil and other shared packages area: web React dashboard type: test Test additions or changes labels Oct 21, 2026
Signed-off-by: Baylem <zelathis@gmail.com>
Signed-off-by: Baylem <zelathis@gmail.com>
Signed-off-by: Baylem <zelathis@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: e2e kind-based end-to-end suite area: shared netguard, gameaction, gameproto, svcutil and other shared packages area: web React dashboard type: test Test additions or changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs/ops: define and exercise panel database, Kubernetes state, and key recovery

1 participant