Repository navigation
[Bug] The test suite requires an undeclared trash binary and fails on a clean machine #73
Description
Predicted by adversarial review of #60 and then proven by CI on its first run.
The test helpers delete fixture directories with Bun.$`trash ${dir}` rather than rm -rf, a deliberate safety choice. trash is not an npm dependency of the tree, bun install never provides it, and four of the five scripts under scripts/ also require it.
On a clean ubuntu-latest runner the result is bun: command not found: trash and 26 of 1,111 tests fail, all in upstream-watch and policy-input-schema. Anyone following the README on Linux hits the same thing.
Worked around in .github/workflows/reference-implementation.yml by installing trash-cli pinned to 7.2.0, so CI exercises the suite. The underlying defect stands: a contributor cloning the repository and running bun test gets 26 failures and no explanation. Either declare the dependency and document it, or have the helper fall back to a plain recursive delete on a path the test itself created under the temp directory.
Metadata
Metadata
Assignees
Labels
Type
Projects
- Status
Activity
aaronormerod commentedon Oct 11, 2026
README and the scripts now say trash is required, so the docs half is covered. What's left is that a bare
bun teston a clean machine still fails those 26 tests. Two fixes: pin trash-cli as a devDependency, or fall back to fs.rm in the helper, scoped to dirs the test made under tmpdir. The code says never rm -rf, so I'd rather not pick for you. Which one do you want?drk-ram commentedon Oct 31, 2026
I am working on this issue in PR #345.
fix(conformance): fall back to tmpdir-scoped rmSync in test cleanup w…
fix(conformance): fall back to tmpdir-scoped rmSync in test cleanup w…