Repository navigation
docs(inspect): add skill component trigger to AgBOM update-trigger list - #338
Conversation
|
This pull request's description says it closes #120, which is on the project roadmap. When it merges, GitHub closes that issue and the roadmap counts it as delivered. Please confirm the change delivers the whole issue before merging. |
Add 'Skill registered, unloaded, or definition-changed.' to the Triggers for AgBOM updates section in docs/spec/inspect/README.md so all eight AgBOM component types in agbom/component.json have a corresponding update trigger, and guard the list in tests/test_hook_taxonomy.py. Fixes GenAI-Security-Project#120 Signed-off-by: Raghuvar Karthik Durga <177662415+drk-ram@users.noreply.github.com>
18a2cde to
78edcb6
Compare
rocklambros
left a comment
There was a problem hiding this comment.
Raghuvar, your new line uses the exact words issue #120 asks for. The agbom/changed schema has a place for each event: added for a registered skill, removed for an unloaded skill, and changed for a changed definition. I checked your change against all of issue #120, and this PR closes it.
I ran this on integration 19b1197. 924 tests passed and 1 was skipped. That's the integration count plus your new test. mkdocs build --strict passed, and Bun 1.3.11 and 1.3.14 gave the same counts as integration.
Your test fails without the new line and passes with it. It also fails if component.json gets a new type with no trigger line, so it will catch this problem next time.
I'm approving this. I need one thing from you before I can merge.
- Please leave a comment on issue #120, as I asked on PR #334. GitHub still won't let me assign you the issue, and I can't merge until you're assigned.
Please don't push to this branch. A push removes my approval.
You don't need to change these two things. docs/spec/inspect/README.md:5 also leaves out skills, but that line is older than your PR and it's outside issue #120. The first sentence of issue #120 also names a skill load, but the text it proposes doesn't. You used the proposed text.
PR #340 and PR #341 add their tests at the same place in tests/test_hook_taxonomy.py, so both will conflict when this merges. I'll ask you to rebase them after that.
|
Thank you very much @rocklambros for the repository invitation, the opportunity to contribute to ACS, and the detailed reviews across the pull requests! I have accepted the repository invitation and left a comment on issue #120 (as well as the other linked issues) so GitHub will allow you to assign them. Leaving this branch untouched as requested so your approval stays intact. |
f3dab50
into
GenAI-Security-Project:integration
What changed
Adds
Skill registered, unloaded, or definition-changed.to## Triggers for AgBOM updatesindocs/spec/inspect/README.mdso all eight component types inspecification/v0.1.0/agbom/component.jsonhave a corresponding update trigger, and adds a guard test intests/test_hook_taxonomy.py.Which issue does this implement
Fixes #120
meaning, so it needs no issue
Base branch
integration, because this touches the specification, schemas, a referenceimplementation, an adapter, tests, or CI
main, because every changed path is on the documentation lane allowlist inCONTRIBUTING.md
Type of change
Specification changes
Breaking for implementers? No. Aligns the prose trigger list in
docs/spec/inspect/README.mdwith the existingskillcomponent type inagbom/component.jsonandhooks/skill-register.json/hooks/skill-unload.json.I tested this
uv run pytest -vpasses on my machineuv run mkdocs build --strictpasses on my machineChecklist
git commit -s(required by the DCO)Security