Skip to content

docs(inspect): add skill component trigger to AgBOM update-trigger list - #338

Merged
rocklambros merged 1 commit into
GenAI-Security-Project:integrationfrom
drk-ram:docs/agbom-skill-update-trigger-120
Oct 31, 2026
Merged

rocklambros merged 1 commit into
GenAI-Security-Project:integrationfrom
drk-ram:docs/agbom-skill-update-trigger-120

Conversation

@drk-ram

@drk-ram drk-ram commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

What changed

Adds Skill registered, unloaded, or definition-changed. to ## Triggers for AgBOM updates in docs/spec/inspect/README.md so all eight component types in specification/v0.1.0/agbom/component.json have a corresponding update trigger, and adds a guard test in tests/test_hook_taxonomy.py.

Which issue does this implement

Fixes #120

  • This is an editorial correction (typo, grammar, link, formatting) with no change in
    meaning, so it needs no issue

Base branch

  • integration, because this touches the specification, schemas, a reference
    implementation, an adapter, tests, or CI
  • main, because every changed path is on the documentation lane allowlist in
    CONTRIBUTING.md

Type of change

  • Specification change (schema, hooks, events, AgBOM)
  • Reference implementation or adapter
  • Documentation
  • Tooling or CI
  • Governance (licensing, security policy, contributor docs)

Specification changes

  • I opened a Discussion before this PR
  • Schema changes validate against the JSON Schema spec
  • I described the impact on downstream implementers below

Breaking for implementers? No. Aligns the prose trigger list in docs/spec/inspect/README.md with the existing skill component type in agbom/component.json and hooks/skill-register.json / hooks/skill-unload.json.

I tested this

  • I synced my branch with the base branch before opening this
  • uv run pytest -v passes on my machine
  • uv run mkdocs build --strict passes on my machine

Checklist

  • Commits are signed off with git commit -s (required by the DCO)
  • Prose follows STYLE.md
  • No secrets, tokens, or internal URLs in the diff

Security

  • This change has no security impact

@github-actions

Copy link
Copy Markdown

This pull request's description says it closes #120, which is on the project roadmap. When it merges, GitHub closes that issue and the roadmap counts it as delivered. Please confirm the change delivers the whole issue before merging.

@drk-ram
drk-ram requested a review from Lrd0036 as a code owner October 28, 2026 05:13
Add 'Skill registered, unloaded, or definition-changed.' to the Triggers
for AgBOM updates section in docs/spec/inspect/README.md so all eight
AgBOM component types in agbom/component.json have a corresponding update
trigger, and guard the list in tests/test_hook_taxonomy.py.

Fixes GenAI-Security-Project#120

Signed-off-by: Raghuvar Karthik Durga <177662415+drk-ram@users.noreply.github.com>

@rocklambros rocklambros left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raghuvar, your new line uses the exact words issue #120 asks for. The agbom/changed schema has a place for each event: added for a registered skill, removed for an unloaded skill, and changed for a changed definition. I checked your change against all of issue #120, and this PR closes it.

I ran this on integration 19b1197. 924 tests passed and 1 was skipped. That's the integration count plus your new test. mkdocs build --strict passed, and Bun 1.3.11 and 1.3.14 gave the same counts as integration.

Your test fails without the new line and passes with it. It also fails if component.json gets a new type with no trigger line, so it will catch this problem next time.

I'm approving this. I need one thing from you before I can merge.

  1. Please leave a comment on issue #120, as I asked on PR #334. GitHub still won't let me assign you the issue, and I can't merge until you're assigned.

Please don't push to this branch. A push removes my approval.

You don't need to change these two things. docs/spec/inspect/README.md:5 also leaves out skills, but that line is older than your PR and it's outside issue #120. The first sentence of issue #120 also names a skill load, but the text it proposes doesn't. You used the proposed text.

PR #340 and PR #341 add their tests at the same place in tests/test_hook_taxonomy.py, so both will conflict when this merges. I'll ask you to rebase them after that.

@drk-ram

drk-ram commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator Author

Thank you very much @rocklambros for the repository invitation, the opportunity to contribute to ACS, and the detailed reviews across the pull requests! I have accepted the repository invitation and left a comment on issue #120 (as well as the other linked issues) so GitHub will allow you to assign them. Leaving this branch untouched as requested so your approval stays intact.

@rocklambros
rocklambros merged commit f3dab50 into GenAI-Security-Project:integration Oct 31, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in ACS Project Tracker Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Bug] AgBOM update-trigger list omits the skill component type

2 participants