Repository navigation
Flag a pull request no lead asked for with one small check - #406
Merged
Merged
Conversation
The intake bot now reads the facts the project asked about. A pull request is flagged when its author is not a lead in GOVERNANCE.md, no lead assigned them on a referenced issue, and no lead reviewed it. The flag is the status:needs-triage label and one short comment. It blocks nothing and always exits 0. Copying a number from the accepted list no longer clears the flag, and the editorial box no longer does either. The check runs from the base commit, so the job gains contents: read and a pinned checkout, and it still runs nothing from the pull request. Closes #362 Closes #369 Signed-off-by: rocklambros <rock@rockcyber.com>
Collaborator
Author
|
@bar-capsule @afogel could one of you review this? It touches |
10 of 24 tasks
A login that only starts with github-actions no longer suppresses the flag. The check stops running on reopen. The comment and the contributor text say what happens now: a lead reads a pull request when they have time, help wanted work starts with an assignment, and a long wait may end in a close. Signed-off-by: rocklambros <rock@rockcyber.com>
|
This pull request's description says it closes #362, which is on the project roadmap. When it merges, GitHub closes that issue and the roadmap counts it as delivered. Please confirm the change delivers the whole issue before merging. |
This was referenced Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This replaces the intake bash with one small check,
tools/pr_intake.py. It replaces PR #368. A pull request is flagged only when its author is not a lead in GOVERNANCE.md, no lead assigned them on a referenced issue, and no lead reviewed it. A flag is thestatus:needs-triagelabel and one short comment. It blocks nothing, changes no auto-merge setting, and needs no rollout.Which issue does this implement
Closes #362
meaning, so it needs no issue
Base branch
integration, because this touches the specification, schemas, a referenceimplementation, an adapter, tests, or CI
main, because every changed path is on the documentation lane allowlist inCONTRIBUTING.md
Type of change
I tested this
uv run pytest -vpasses on my machineuv run mkdocs build --strictpasses on my machineI also ran the script against live pull requests with writes stubbed. It flagged an outsider, stayed quiet on a lead's assignment, a lead's review, and an existing queue comment, and exited 0 each time.
Checklist
git commit -s(required by the DCO)Security
The workflow stays on
pull_request_target, which holds a write token. The job now checks out the base commit it runs from, withpersist-credentials: false, and addscontents: read. It never touches the pull request's head, and only digits are read from the description. A test pins this.Behavior to check
status:acceptedissue no longer clears the flag. Neither does the editorial box.