Skip to content

Flag a pull request no lead asked for with one small check - #406

Merged
rocklambros merged 2 commits into
integrationfrom
fix/362-small-intake
Nov 1, 2026
Merged

rocklambros merged 2 commits into
integrationfrom
fix/362-small-intake

Conversation

@rocklambros

@rocklambros rocklambros commented Nov 1, 2026 •

Copy link
Copy Markdown
Collaborator

What changed

This replaces the intake bash with one small check, tools/pr_intake.py. It replaces PR #368. A pull request is flagged only when its author is not a lead in GOVERNANCE.md, no lead assigned them on a referenced issue, and no lead reviewed it. A flag is the status:needs-triage label and one short comment. It blocks nothing, changes no auto-merge setting, and needs no rollout.

Which issue does this implement

Closes #362

  • This is an editorial correction (typo, grammar, link, formatting) with no change in
    meaning, so it needs no issue

Base branch

  • integration, because this touches the specification, schemas, a reference
    implementation, an adapter, tests, or CI
  • main, because every changed path is on the documentation lane allowlist in
    CONTRIBUTING.md

Type of change

  • Specification change (schema, hooks, events, AgBOM)
  • Reference implementation or adapter
  • Documentation
  • Tooling or CI
  • Governance (licensing, security policy, contributor docs)

I tested this

  • I synced my branch with the base branch before opening this
  • uv run pytest -v passes on my machine
  • uv run mkdocs build --strict passes on my machine

I also ran the script against live pull requests with writes stubbed. It flagged an outsider, stayed quiet on a lead's assignment, a lead's review, and an existing queue comment, and exited 0 each time.

Checklist

  • Commits are signed off with git commit -s (required by the DCO)
  • Prose follows STYLE.md
  • No secrets, tokens, or internal URLs in the diff

Security

  • This change has no security impact

The workflow stays on pull_request_target, which holds a write token. The job now checks out the base commit it runs from, with persist-credentials: false, and adds contents: read. It never touches the pull request's head, and only digits are read from the description. A test pins this.

Behavior to check

  • A referenced status:accepted issue no longer clears the flag. Neither does the editorial box.
  • Triage volunteers and owners who are in CODEOWNERS but not GOVERNANCE.md leads get flagged.
  • A review after the flag does not clear it. The lead removes the label, and the bot won't add it back.

The intake bot now reads the facts the project asked about. A pull request is flagged
when its author is not a lead in GOVERNANCE.md, no lead assigned them on a referenced
issue, and no lead reviewed it. The flag is the status:needs-triage label and one short
comment. It blocks nothing and always exits 0.

Copying a number from the accepted list no longer clears the flag, and the editorial box
no longer does either. The check runs from the base commit, so the job gains contents:
read and a pinned checkout, and it still runs nothing from the pull request.

Closes #362
Closes #369

Signed-off-by: rocklambros <rock@rockcyber.com>
@rocklambros

Copy link
Copy Markdown
Collaborator Author

@bar-capsule @afogel could one of you review this? It touches .github/ and replaces PR #368 with a much smaller check.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown

This pull request's description says it closes #362 #369, which is on the project roadmap. When it merges, GitHub closes that issue and the roadmap counts it as delivered. Please confirm the change delivers the whole issue before merging.

A login that only starts with github-actions no longer suppresses the flag. The
check stops running on reopen. The comment and the contributor text say what
happens now: a lead reads a pull request when they have time, help wanted work
starts with an assignment, and a long wait may end in a close.

Signed-off-by: rocklambros <rock@rockcyber.com>
@rocklambros
rocklambros requested a review from Lrd0036 as a code owner November 1, 2026 02:08
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown

This pull request's description says it closes #362, which is on the project roadmap. When it merges, GitHub closes that issue and the roadmap counts it as delivered. Please confirm the change delivers the whole issue before merging.

@rocklambros
rocklambros merged commit 895fe60 into integration Nov 1, 2026
11 of 12 checks passed
@github-project-automation github-project-automation Bot moved this from Needs triage to Done in ACS Project Tracker Nov 1, 2026
@rocklambros
rocklambros deleted the fix/362-small-intake branch November 1, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

PR intake: one gate for work no maintainer asked for

1 participant