Repository navigation
Show contributors how to sign their commits - #417
Merged
Merged
Conversation
The dco check is now required on integration, and many contributors have never signed off a commit. Add a section to CONTRIBUTING.md that assumes no prior knowledge, and point the check's failure message at it. Signed-off-by: rocklambros <rock@rockcyber.com>
rocklambros
requested review from
GangGreenTemperTatum,
bar-capsule,
fewdisc,
mamicidal and
sclintonowasp
as code owners
November 1, 2026 02:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The
dcocheck is now required onintegration, and many contributors have never signed off a commit. This adds a "How to sign your commits" section to CONTRIBUTING.md that assumes no prior knowledge, and points the check's failure message at it.Which issue does this implement
Refs #52
meaning, so it needs no issue
Base branch
integration, because this touches the specification, schemas, a referenceimplementation, an adapter, tests, or CI
main, because every changed path is on the documentation lane allowlist inCONTRIBUTING.md
Type of change
I tested this
uv run pytest -vpasses on my machineuv run mkdocs build --strictpasses on my machineThe rebase steps ran on copies of PR #223, PR #246, and PR #297 with no conflicts and left no unsigned commit. A separate scratch repository confirmed that a sign-off survives a conflict and
git rebase --continue, and that--signoffworks on a branch already at the tip.Checklist
git commit -s(required by the DCO)Security