Skip to content

Show contributors how to sign their commits - #417

Merged
rocklambros merged 1 commit into
integrationfrom
docs/sign-your-commits
Nov 1, 2026
Merged

rocklambros merged 1 commit into
integrationfrom
docs/sign-your-commits

Conversation

@rocklambros

Copy link
Copy Markdown
Collaborator

What changed

The dco check is now required on integration, and many contributors have never signed off a commit. This adds a "How to sign your commits" section to CONTRIBUTING.md that assumes no prior knowledge, and points the check's failure message at it.

Which issue does this implement

Refs #52

  • This is an editorial correction (typo, grammar, link, formatting) with no change in
    meaning, so it needs no issue

Base branch

  • integration, because this touches the specification, schemas, a reference
    implementation, an adapter, tests, or CI
  • main, because every changed path is on the documentation lane allowlist in
    CONTRIBUTING.md

Type of change

  • Specification change (schema, hooks, events, AgBOM)
  • Reference implementation or adapter
  • Documentation
  • Tooling or CI
  • Governance (licensing, security policy, contributor docs)

I tested this

  • I synced my branch with the base branch before opening this
  • uv run pytest -v passes on my machine
  • uv run mkdocs build --strict passes on my machine

The rebase steps ran on copies of PR #223, PR #246, and PR #297 with no conflicts and left no unsigned commit. A separate scratch repository confirmed that a sign-off survives a conflict and git rebase --continue, and that --signoff works on a branch already at the tip.

Checklist

  • Commits are signed off with git commit -s (required by the DCO)
  • Prose follows STYLE.md
  • No secrets, tokens, or internal URLs in the diff

Security

  • This change has no security impact

The dco check is now required on integration, and many contributors have never signed off a commit. Add a section to CONTRIBUTING.md that assumes no prior knowledge, and point the check's failure message at it.

Signed-off-by: rocklambros <rock@rockcyber.com>
@rocklambros
rocklambros requested a review from afogel as a code owner November 1, 2026 02:19
@github-project-automation github-project-automation Bot moved this to Needs triage in ACS Project Tracker Nov 1, 2026
@rocklambros
rocklambros merged commit 5cbcfa1 into integration Nov 1, 2026
12 checks passed
@github-project-automation github-project-automation Bot moved this from Needs triage to Done in ACS Project Tracker Nov 1, 2026
@rocklambros
rocklambros deleted the docs/sign-your-commits branch November 1, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant