Repository navigation
Give the landing page the same header and navigation as the docs - #445
Merged
Merged
Conversation
…home The two surfaces shared their rows through extra.acs_nav, but each had its own markup and CSS, and the tests compared rows only. So the landing page said ACS in wide tracking, had no top header on desktop, and drew its pane differently, with every test green. The landing page now carries the docs header at every width: icon, title, theme toggle, Search, and the repository link. The title and repository values come from mkdocs.yml through new placeholders, validated and escaped like the pane's values. Search links to the docs field because this page has no index. The pane takes the docs fonts, spacing, chevrons, accent color, and External resources heading. The drawer opens at the docs breakpoint, below the header, so its toggle stays reachable. Chrome sizes use a unit that tracks the docs rem, because this page's own rem has to stay 16px. The icon and the title now link to the homepage on both surfaces, on every page. The docs had the logo on /docs/ and no title link. A new header.html override derives the target the way the pane's Home row does, so it holds on the custom domain, on the project subpath, and on the 404 page. Tests hold the wordmark and pane title to site_name, the landing header to the docs header, and the home links across every built page. Signed-off-by: rocklambros <rock@rockcyber.com>
rocklambros
requested review from
GangGreenTemperTatum,
Lrd0036,
afogel,
bar-capsule,
fewdisc,
mamicidal and
sclintonowasp
as code owners
November 1, 2026 11:15
github-project-automation
Bot
moved this from Needs triage
to Done
in ACS Project Tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Gives the landing page the same top header and left pane as the docs pages: icon, title, theme toggle, Search, GitHub link, pane title, chevrons, accent color, and the External resources heading. The title comes from
site_nameinmkdocs.ymleverywhere. The icon and title link to the homepage on every docs page, the 404 page, and the landing page.PR #366 shared the rows, but each surface kept its own markup and CSS, and the tests compared only the rows. New tests now pin the title and the home links on both surfaces.
Which issue does this implement
Closes #444
Base branch
integrationType of change
I tested this
uv run pytest -q: 1210 passed, 1 skippeduv run mkdocs build --strict: passedChecklist
Signed-off-byline viagit commit -sSTYLE.mdSecurity
site_namereaches the page escaped. The content security policy adds nothing, and the page loads no new third-party resource.