Repository navigation
fix(agt-bridge): refuse a manifest bundle that disables policy - #519
Open
aaronormerod wants to merge 1 commit into
Open
aaronormerod wants to merge 1 commit into
aaronormerod wants to merge 1 commit into
Conversation
createBridge checked the manifest path for /./, which did not disable policy when measured. The bundle: value does. ./lib, lib/., ./lib/, lib/./, lib/../lib, sub/../lib, ../policy/lib, .//lib, lib// and sub//lib each answered allow for rm -rf /. . and lib/.. denied every step. Refuse a bundle with a . or .. segment or a path that is not normalized. lib, lib/, sub/lib and an absolute path are unchanged. Closes GenAI-Security-Project#374 Signed-off-by: aaronormerod <137795541+aaronormerod@users.noreply.github.com>
aaronormerod
requested review from
GangGreenTemperTatum,
afogel,
artmaro,
bar-capsule,
fewdisc,
mamicidal,
rocklambros and
sclintonowasp
as code owners
November 6, 2026 21:12
github-actions
Bot
added
the
status:needs-triage
|
Thanks for this. It is queued rather than ignored. A lead has not reviewed this pull request yet. A lead will read it when they have time, and we can't promise a date. Nothing here is rejected. If a check below fails, please fix it. A pull request that waits a long time may be closed, and you can reopen it later. |
|
This pull request's description says it closes #374, which is on the project roadmap. When it merges, GitHub closes that issue and the roadmap counts it as delivered. Please confirm the change delivers the whole issue before merging. |
acs-board-reconciler
Bot
moved this from Needs triage
to In progress
in ACS Project Tracker
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
createBridgenow reads the manifest and refuses abundle:with a.or..segment or a path that is not normalized. Measured withrm -rf /as the step:./lib,lib/.,./lib/,lib/./,lib/../lib,sub/../lib,../policy/lib,.//lib,lib//andsub//libreturnedallow..andlib/..denied every step.lib,lib/,sub/liband an absolute path are unchanged. A/./in the manifest path, which the old guard checks, did not disable policy when measured.Which issue does this implement
Closes #374
Base branch
integration, because this touches a reference implementation and testsType of change
I tested this
uv run pytest -vpasses on my machineuv run mkdocs build --strictpasses on my machineAlso
bun testinreference-implementations/agt: 1316 pass, 0 fail, 4 skip, on Bun 1.3.11.bun run typecheckpasses on Node 20. A Guardian started onbundle: ./libexits with code 1.Checklist
git commit -s(required by the DCO)Security
A manifest that allowed destructive steps now stops the bridge at startup.