Repository navigation
Add Betterleaks secret scanning to CI - #108
shubham-s-pandey wants to merge 3 commits into
Conversation
Signed-off-by: Shubham Pandey <56669789+shubham-s-pandey@users.noreply.github.com>
Signed-off-by: Shubham Pandey <56669789+shubham-s-pandey@users.noreply.github.com>
drk-ram
left a comment
There was a problem hiding this comment.
Security peer review of commit f6e35a89173c44e60c594c3fa9e4ff766ed7b997.
No exploitable security vulnerability found in the changed workflow or rule configuration. The job uses read-only repository permission, does not persist checkout credentials, and mounts the checkout read-only into a non-root container. It uses the unprivileged pull-request event rather than the privileged target event. Credential validation, analysis, revocation, and environment forwarding are not enabled by the container invocation, so the provider-request expressions are not active in this job. I compared the complete configuration with the official v2.0.0-rc.1 release configuration and inspected the differences.
Tests at that exact commit: 8 in-memory configuration/security checks passed, 0 failed, covering YAML/TOML parsing, all 466 rule identifiers and component references, event privilege, permissions, credential persistence, mount restrictions, invocation arguments, and version agreement. 0 container/scanner execution tests: Docker and the scanner executable are unavailable on this host. This approval is based on the reviewed configuration and those checks, not a claim that the container run was exercised.
Updated the GitHub Actions workflow to use 'pull_request_target' and changed the default branch from 'master' to 'main'. Modified the Betterleaks scan step to use the latest Docker image and adjusted paths for trusted and scan repositories. Signed-off-by: Shubham Pandey <56669789+shubham-s-pandey@users.noreply.github.com>
|
|
@saquibsaifee @eaglei15 Hi team, PR are ready for merge. Could someone please take a final look and merge PR. Thanks! |
|
@shubham-s-pandey, do you have an issue created for this feature? |
|
@saquibsaifee No, If required I can create an issue for this PR. |
|
@saquibsaifee @eaglei15 Hi team, PR are ready for merge. Could someone please take a final look and merge PR. Thanks! |
Summary
Add a Betterleaks secret-scanning workflow for pull requests and pushes to the default branch.
Scope
Validation
v2.0.0-rc.1.