Repository navigation
Conversation
drk-ram
approved these changes
Nov 2, 2026
drk-ram
left a comment
There was a problem hiding this comment.
I checked 5ed6279 and traced both export strings through the result page and the existing download helper.
All three web-controller tests pass. Replacing tojson with safe independently for each constant makes the contributed regression fail.
I checked four payloads against both constants, including </script><script>alert(1)</script>, mixed-case terminators, comment prefixes, quotes, and Unicode separators.
The rendered expressions contain no literal opening angle brackets. Decoding them reproduces the saved 1.6 and 1.7 documents exactly.
The values now remain strings, which downloadJSON already supports without double-encoding downloads.
No blocker in these two template changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Serialize generated CycloneDX JSON with the context-aware Jinja tojson filter, preventing model metadata from terminating the surrounding script element. Adds a script-terminator regression test. Testing: targeted web-controller tests and the full test suite pass.