Skip to content

fix(api): report project version in status response - #116

Open
andife wants to merge 1 commit into
GenAI-Security-Project:mainfrom
andife:fix/status-project-version
Open

andife wants to merge 1 commit into
GenAI-Security-Project:mainfrom
andife:fix/status-project-version

Conversation

@andife

@andife andife commented Oct 18, 2026

Copy link
Copy Markdown

Summary: Source both status version fields from project metadata instead of stale hard-coded values and add endpoint coverage. Testing: web-controller tests pass.

@drk-ram drk-ram left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed both changed files at a8161038f1ed4f08cc90cc1feba15e22d9b6ac32. Approved.

src/controllers/web_controller.py:58-63 now sources both status version fields from the same existing metadata-derived constant used elsewhere in the generator. This removes two divergent hard-coded values without changing the route, response keys, or operational-status value.

Validation: python -m pytest tests\test_web_controller.py -k status -q --no-cov passed. I additionally mounted the actual router, substituted the distinctive version 9.8.7-review, and verified that /status returned that value in both fields with HTTP 200; the direct coroutine result agreed.

Non-blocking test improvement: consider retaining that sentinel-version substitution in the regression test. It makes the synchronization contract explicit even when the ordinary project version later changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants