Repository navigation
Conversation
CI installed unpinned packages and now gets Starlette 1.x, FastAPI 0.162 and SQLAlchemy 2.1, which fail test_vendor_isolation.py on every pull request (5 failures on main). uv.lock already pins versions that pass, so install from it with `uv sync --frozen` and run each step with `uv run`. The lock file includes pytest, gspread and google-auth, so the optional Google Sheets reporting is unchanged. Reproduced in a fresh clone: vendor isolation 13 passed, session management 14 passed, complete user isolation 9 passed, redis message streams 26 passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI installs unpinned packages, so it now picks up Starlette 1.x, FastAPI 0.162 and SQLAlchemy 2.1. With those,
tests/unit/vendor/test_vendor_isolation.pyfails on every pull request: 5 failures onmain. The repo already pins working versions inuv.lock, so this makes the job use it.Change
uv sync --frozeninstead ofpip install -e ".[dev]"plus extra packages. The lock file already includes pytest, pytest-cov, gspread and google-auth.uv run.The optional Google Sheets reporting is unchanged: it still runs only when the secrets are set.
Verified
Fresh clone, same commands as the job:
uv.lock(this PR)Why it matters
Today every pull request that runs CI fails this job, whatever it changes. With the lock file, a new release can't break CI until someone updates
uv.lockon purpose.