Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MCPToolProvider._log_activityperformed a synchronous SQLAlchemydb_session()write directly on the async event loop. This is a hot path, it fires on every MCP tool call (pre-call, success, and failure paths) plus once per server duringconnect(). Under concurrent sessions this serializes all MCP tool executions through the event loop, adding DB round-trip latency to every agent action and contributing to connection pool pressure.Fix
_log_activity_sync(private sync helper)._log_activityanasync defthat dispatches toasyncio.to_thread(_log_activity_sync, ...), keeping the event loop unblocked.awaitall five call sites: one inconnect(), three incall_mcp_tool().import asyncio.Behaviour
No change to the audit log, writes still happen, just on a thread-pool worker. The fix is non-breaking;
_log_activity_syncis a private method and no external callers exist.