Repository navigation
fix(detectors): safely parse request_dump and response_dump JSON in SystemPromptLeakDetector - #627
Open
ojaswa072 wants to merge 1 commit into
Conversation
…ystemPromptLeakDetector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ContextualLLMClientstoresrequest_dumpandresponse_dumpas serialized JSON strings (.model_dump_json()) within the event payload. InSystemPromptLeakDetector._extract_texts, both fields were directly accessed as dictionaries (request_dump.get("messages"),response_dump.get("content")). When encountering string payloads, this resulted in anAttributeErroror failure to extract system prompts and agent output, rendering system prompt leak challenges inoperative.Fix
import json.request_dumpandresponse_dumpfrom JSON strings to dictionaries with exception guards (json.JSONDecodeError,TypeError).Nonecontent values (message.get("content") or "").