Repository navigation
test: bracket the scoped database size by both system readings - #141
Merged
Merged
Conversation
The deployment-wide size check read the database size as the system scope before and after the scoped read and required the three readings to grow in order. On PostgreSQL pg_database_size can shrink between two readings when a vacuum truncates a relation or temporary files go away, so the check failed while every count was right. The scoped reading is now accepted when it lies between the two system readings in either order.
Coverage report
This PR does not seem to contain any modification to coverable code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The access-scope case that proves
database_size_mbis a deployment-wide figure read the size as the system scope before and after the scoped read and required the three readings to grow in order. On PostgreSQLpg_database_sizecan shrink between two readings when a vacuum truncates a relation or temporary files go away, so the case failed in a full-suite run while every count it checked was right.What changes
The scoped reading is accepted when it lies between the two system readings in either order. The case keeps proving the same property: the figure a caller sees is the deployment's size, never a per-scope one.