Skip to content
This repository was archived by the owner on Oct 26, 2026. It is now read-only.

[SECURITY-19867] Pin Node.js to 22.23.4 (CVE-2026-111497) - #1

Draft
goodbot-agent[bot] wants to merge 2 commits into
mainfrom
security-19867-goodbot-node2shell-pin-lifecycle-oss-to-
Draft

goodbot-agent[bot] wants to merge 2 commits into
mainfrom
security-19867-goodbot-node2shell-pin-lifecycle-oss-to-

Conversation

@goodbot-agent

@goodbot-agent goodbot-agent Bot commented Oct 23, 2026

Copy link
Copy Markdown

Summary

  • Pin Node.js to 22.23.4 in both root Dockerfiles, .nvmrc, mise, and four additional repo-owned Node runtime Dockerfiles.
  • GoodRx/lifecycle-oss owns the lifecycleoss/app:alpha image: .github/workflows/release.yaml builds app.Dockerfile and tags prereleases alpha. app.Dockerfile currently consumes lifecycleoss/app-base:v2, built from base.Dockerfile by .github/workflows/base-release.yaml. A rebuilt app-base:v2 (or a newly versioned base with an updated BASE_IMAGE_TAG) and rebuilt app image are required before the pin affects alpha. Deployment is separate.

Validation

  • git diff --check: passed. All repo-owned FROM node: lines now specify node:22.23.4-slim.
  • Requested build check output:
    $ docker build --pull -f Dockerfile -t lco-check .
    /usr/bin/bash: line 1: docker: command not found
    
    docker run --rm --entrypoint node lco-check -v could not run without Docker. The built-image Node version remains unverified and needs checking on a machine with Docker.
  • .github/workflows/ci.yaml remains at 22.x: the GitHub App rejected a push modifying workflows because it lacks workflows permission. A workflow-authorized actor should pin CI to 22.23.4.

Jira: https://goodrx-dev.atlassian.net/browse/SECURITY-19867
GoodBot session: https://goodbot.grxweb.com/sessions/4d98ca1a-375f-4cfc-bb67-458760d10fa5

Use the fixed Node.js patch for the app base, local development, CI, and auxiliary runtime images to address CVE-2026-111497. The release image consumes app-base:v2; publishing a rebuilt base and app image is required for the runtime fix to reach alpha.
…mission

The GitHub App cannot push workflow changes. Keep the runtime image and local Node pins in this PR; CI remains on 22.x until a workflow-authorized actor can update it.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants