Skip to content

fix: require scoped log tickets in CLI 0.8.0 - #19

Draft
vmelikyan wants to merge 2 commits into
mainfrom
security/log-stream-tickets
Draft

vmelikyan wants to merge 2 commits into
mainfrom
security/log-stream-tickets

Conversation

@vmelikyan

@vmelikyan vmelikyan commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

CLI log commands now obtain a scoped ticket before opening a WebSocket. The client reports an incompatible API instead of falling back to anonymous streaming. Version 0.8.0 and the versioned User-Agent distinguish this contract from 0.7.1. Generated MCP discovery state also matches the API.

Based on main 42afe8e, with separate commits bed6d2a and d42f7ae. Release this CLI after the ticket issuer and enforcing WebSocket backend are available. CLI 0.7.1 and older lose live log streaming after enforcement; users must update and rerun disconnected commands. No package or tag has been published by this PR.

Validation

  • 135 tests passed for the ticket implementation; 26 focused version/error tests passed after the wording/version change.
  • At d42f7ae, Node 24.13.1: frozen dependency install, typecheck, production build, help and version smoke passed (0.8.0).
  • Independent Opus 5.5 Max source review verified target/error handling, ticket-only behavior and the versioned client.

Live pod logs and a deploy-job stream passed against API 7ac03a7e with this exact CLI build. Companion API probes verified repository restriction, revoked credentials and natural ticket expiry. These probes do not establish CLI reconnect, archived-log variants or mixed-version behavior. Those remain release gates, so the PR stays in draft. No authored GUI text changed. Commit and PR text review passed: compatibility, validation and publication status are explicit.

Matching API: GoodRxOSS/lifecycle#273.
Matching UI: https://github.com/GoodRxOSS/lifecycle-ui/pull/97.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant