Repository navigation
fix(docker): pin pnpm to the packageManager version - #270
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The images installed whatever pnpm was latest (
npm install pnpm --global) even thoughpackage.jsonpinspackageManager: pnpm@9.15.0. A newer global pnpm only works by downloading and switching to 9.15.0 at run time, and logs that it ignoredpnpm.overrides.Changes
Dockerfile,app.Dockerfile,base.Dockerfile: pin pnpm withARG PNPM_VERSION=9.15.0(matchespackageManagerinpackage.json; keep them in sync).app.Dockerfileinstalls it too, so the result doesn't depend on the pnpm already in the published base image.Verification
--target packages). In both,node_modules/.pnpmmatchespnpm-lock.yamlfor every override target (@kubernetes/client-node0.22.3,form-data2.5.6,qs6.16.1,micromatch4.0.8,yaml2.9.1,postcss8.5.31). So the overrides were already applied at install time./app.pnpm lintandpnpm buildpass on Node 22.pnpm ts-checkand onebuild.test.tstest fail identically on unmodifiedmain.app.Dockerfilewas not built, because its base image is pulled from a registry. It uses the same install line asDockerfile.