Skip to content

fix(agent-admin): sort session review list by creation time #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vmelikyan merged 1 commit into from
Oct 29, 2026
Merged

fix(agent-admin): sort session review list by creation time #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/app/api/v2/ai/admin/agent/sessions/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import AgentAdminService from 'server/services/agent/AdminService';
* user or assistant message. Empty sessions and system-event-only sessions are excluded.
* Sessions remain visible while waiting for an assistant response to a user's first message.
* Results can be filtered by status, repository, user, and build UUID.
* Sessions are sorted newest first by creation time.
* tags:
* - Agent Admin
* operationId: getAdminAgentSessions
Expand Down
2 changes: 1 addition & 1 deletion src/server/services/agent/AdminService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ export default class AgentAdminService {
});
}

const sessions = await query.orderBy('updatedAt', 'desc').orderBy('createdAt', 'desc');
const sessions = await query.orderBy('createdAt', 'desc').orderBy('id', 'desc');
const sessionDbIdByUuid = new Map(sessions.map((session) => [session.uuid, session.id]));
const enrichedSessions = await AgentSessionService.enrichSessions(sessions);

Expand Down
2 changes: 2 additions & 0 deletions src/server/services/agent/__tests__/AdminService.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,6 +426,8 @@ describe('AgentAdminService.listSessions', () => {

const result = await AgentAdminService.listSessions({});

expect(sessionQueryBuilder.orderBy).toHaveBeenNthCalledWith(1, 'createdAt', 'desc');
expect(sessionQueryBuilder.orderBy).toHaveBeenNthCalledWith(2, 'id', 'desc');
expect(threadWhereIn).toHaveBeenCalledWith('sessionId', [101, 202]);
expect(pendingWhereIn).toHaveBeenCalledWith('thread.sessionId', [101, 202]);
expect(result.data).toEqual([
Expand Down
Loading