Skip to content

chore(functions): update hello-firestore dependencies#14375

Open
XrossFox wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
XrossFox:package-update-protobuf-functions-firebase-hello-firestore
Open

chore(functions): update hello-firestore dependencies#14375
XrossFox wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
XrossFox:package-update-protobuf-functions-firebase-hello-firestore

Conversation

@XrossFox

@XrossFox XrossFox commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Description

  • Bump protobuf, functions-framework, google-api-core, and cloudevents.
  • Remove python version constraint for pytest.

Fixes b/527483064

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.

Compliance & Style


Post-Approval Actions

  • Please merge this PR for me once it is approved

   - Bump protobuf, functions-framework, google-api-core, and cloudevents.
   - Remove python version constraint for pytest.
@product-auto-label product-auto-label Bot added api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples. labels Jul 2, 2026
@XrossFox

XrossFox commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

This has been tested locally, since it doesn't use nox, it was tested on the base python installation on my system:

image

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates dependency versions in the requirements files for the hello-firestore Firebase function. The review feedback suggests sorting the dependencies in requirements.txt alphabetically and adding a trailing newline to improve maintainability and ensure standard POSIX compliance.

Comment thread functions/v2/firebase/hello-firestore/requirements.txt

@amcolin amcolin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XrossFox XrossFox marked this pull request as ready for review July 3, 2026 22:06
@XrossFox XrossFox requested review from a team as code owners July 3, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants