Repository navigation
Improve dictionary construction errors - #35
Merged
Merged
Conversation
CarlOlsson
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the error reported when
from_dictcannot construct a requested type from a dictionary.Previously, the final error printed the complete dictionary and always suggested adding a type key. That suggestion could be misleading when a type tag had already resolved to a concrete type and construction subsequently failed because its fields did not match.
The new error explains the construction strategies PortableStructs considered and identifies the relevant key mismatch.
Changes
Anyor abstract.Symbolfails.This does not add keywords or change the
from_dictextension interface. Construction failures remainErrorExceptions.Examples
For a concrete type with mismatched keys:
If a type tag resolves to
ConcreteConfigbut its dictionary contains the wrong fields, the error describes that concrete construction failure:It does not incorrectly suggest adding another type tag.
For an untagged abstract type, the error retains a useful subtype suggestion:
Testing
Added coverage for:
Symbolthrows.ErrorExceptiontype.The complete PortableStructs test suite passes:
julia --project=test -e 'import Pkg; Pkg.test("PortableStructs")'