Repository navigation
Preserve key order when expanding included mappings - #37
Merged
Merged
Conversation
CarlOlsson
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR preserves mapping key order when expanding YAML and JSON includes.
Previously, include merging used:
Although both inputs are
OrderedDicts,unionreturns aSet. Iterating that set introduces hash ordering, and the resultingOrderedDictpreserves the incorrect order.This is particularly visible when the expanded mapping is converted to a
NamedTuple, because field order contributes to the resulting Julia type.Changes
The include merge now:
For example:
The expanded result retains this order:
The value of
secondis updated without moving the key, andfourthis appended.NamedTuple behavior
The regression coverage compares equivalent inline and included YAML using an explicitly nested
NamedTupletype:The nested annotation is explicit because dictionaries decoded through an untyped
Anyfield remainOrderedDicts.Testing
Added regression coverage for:
NamedTuplefield order, type, and value.The complete PortableStructs test suite passes.
Closes #31