Skip to content

Fix flake8 violations in OI models - #756

Merged
jochengcd merged 2 commits into
GrandComicsDatabase:betafrom
jhunterjActual:fix/models-py-flake8
Sep 19, 2026
Merged

jochengcd merged 2 commits into
GrandComicsDatabase:betafrom
jhunterjActual:fix/models-py-flake8

Conversation

@jhunterjActual

Copy link
Copy Markdown
Contributor

Summary

  • replace the backslash-chained queryset in StoryRevision.copied_revision() with a parenthesized expression
  • wrap the long FeatureNameDetailRevision sort-name assignment
  • preserve existing query and assignment behavior

Testing

  • python -m flake8 apps/oi/models.py
  • python manage.py check
  • python manage.py makemigrations --check --dry-run
  • pytest -q apps/oi/tests/test_story_revision.py apps/oi/tests/db/test_story_revision.py apps/oi/tests/test_series_revision.py (84 passed)

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves code formatting in apps/oi/models.py by removing backslash line continuations and wrapping long lines. The reviewer suggested extracting a nested attribute into a variable to simplify a query and improve readability.

Comment thread apps/oi/models.py Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@jhunterjActual
jhunterjActual marked this pull request as ready for review September 13, 2026 20:47
@jochengcd
jochengcd merged commit ab71b4b into GrandComicsDatabase:beta Sep 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants