Skip to content

fix: Make headless mode work without jsdom #392 - #393

Closed
pboneure wants to merge 4 commits into
GrapesJS:masterfrom
pboneure:ISSUE-392-fixing-headless-mode
Closed

pboneure wants to merge 4 commits into
GrapesJS:masterfrom
pboneure:ISSUE-392-fixing-headless-mode

Conversation

@pboneure

Copy link
Copy Markdown

Remove the use of document element when in headless mode.
Import mjml browser only if another parser wasn't provided.

@gbremond

Copy link
Copy Markdown

Same issue on my side, thank's for the fix !
@artf do you have an opinion on this fix ?

Comment thread src/index.ts Resolved
@pboneure

Copy link
Copy Markdown
Author

Hello @artf can you take a look at this when you've some time please?

@pboneure
pboneure requested a review from artf May 18, 2026 09:33
@droux-bcg

Copy link
Copy Markdown

Hi @artf, I would be interested by this. Could it be merged soon?

Thank you! 🙂

@artf

artf commented Oct 27, 2026

Copy link
Copy Markdown
Member

Sorry for the long delay 🥲 I finally had time to revisit this and found a few more blockers to headless support, including the MJML browser bundle referencing window internally. I ended up reworking parts of the integration in: #439

I’m closing this PR now that those changes have been merged. Thanks for your patience and for putting this together!

@artf artf closed this Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants